-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MNOE-689] API V2 - SubTenant replace mass assignment of relation ship by diff #532
Conversation
x4d3
commented
Oct 13, 2017
- remove clients and account_managers dependency from sub_tenant
- remove clients dependeny from user
- introduce update_clients and update_account_managers endpoint
- replace user.mnoe_sub_tenant_id by sub_tenant_id
- add optional belong_to_subtenant and belong_to_account_manager boolean parameter depending on the sub_tenant_id and account_manager parameter
Depends on maestrano/maestrano-hub#754 |
…p by diff - remove clients and account_managers dependency from sub_tenant - remove clients dependeny from user - introduce update_clients and update_account_managers endpoint - replace user.mnoe_sub_tenant_id by sub_tenant_id
3a9881a
to
01c4352
Compare
.select(INCLUDED_FIELDS) | ||
.with_params(_metadata: { act_as_manager: current_user.id }) | ||
.where(Hash[*t]) | ||
query = query.with_params(sub_tenant_id: params[:sub_tenant_id]) if params[:sub_tenant_id] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is to retreive the belong_to_sub_tenant and belong_to_account_manager property.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍