Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MNOE-689] API V2 - SubTenant replace mass assignment of relation ship by diff #532

Merged
merged 1 commit into from
Nov 9, 2017

Conversation

x4d3
Copy link
Contributor

@x4d3 x4d3 commented Oct 13, 2017

  • remove clients and account_managers dependency from sub_tenant
  • remove clients dependeny from user
  • introduce update_clients and update_account_managers endpoint
  • replace user.mnoe_sub_tenant_id by sub_tenant_id
  • add optional belong_to_subtenant and belong_to_account_manager boolean parameter depending on the sub_tenant_id and account_manager parameter

@ouranos
Copy link
Contributor

ouranos commented Nov 3, 2017

Depends on maestrano/maestrano-hub#754

…p by diff

- remove clients and account_managers dependency from sub_tenant
- remove clients dependeny from user
- introduce update_clients and update_account_managers endpoint
- replace user.mnoe_sub_tenant_id by sub_tenant_id
@x4d3 x4d3 force-pushed the feature/subtenant-v2 branch from 3a9881a to 01c4352 Compare November 8, 2017 17:40
.select(INCLUDED_FIELDS)
.with_params(_metadata: { act_as_manager: current_user.id })
.where(Hash[*t])
query = query.with_params(sub_tenant_id: params[:sub_tenant_id]) if params[:sub_tenant_id]
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is to retreive the belong_to_sub_tenant and belong_to_account_manager property.

@ouranos ouranos added this to the v4.0 milestone Nov 9, 2017
Copy link
Contributor

@ouranos ouranos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@alachaum alachaum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ouranos ouranos merged commit 60239f0 into maestrano:4.0 Nov 9, 2017
@x4d3 x4d3 deleted the feature/subtenant-v2 branch December 20, 2017 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants