[MNOE-857] Allowed organization to be added to staff divisions #640
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MAhsenArif
force-pushed
the
auto_assign_staff_division
branch
2 times, most recently
from
483dd4f to
ecd4152
Compare
ouranos
requested changes
Jan 30, 2018
| @@ -141,5 +142,19 @@ def update_app_list | |||
| existing_apps.reload | |||
| end | |||
| end | |||
|
|
|||
| def update_sub_tenants | |||
| return if params[:organization].key?(:sub_tenant_ids).blank? | |||
There was a problem hiding this comment.
key? returns true or false so no need for blank? here
|
|
||
| sub_tenants = MnoEnterprise::SubTenant.where({'id.in' => params[:organization][:sub_tenant_ids]}) | ||
|
|
||
| sub_tenants.to_a.each do |sub_tnt| |
There was a problem hiding this comment.
This is not really scalable if we have a huge list for client_ids.
See MNOE-869 and the fix added in #532
MAhsenArif
force-pushed
the
auto_assign_staff_division
branch
from
ecd4152 to
82b079e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.