forked from dotnet/roslyn
-
Notifications
You must be signed in to change notification settings - Fork 0
[dkurepa/test] Source code updates from maestro-auth-test/dotnet #10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
maestro-local-dev
wants to merge
233
commits into
dkurepa/test
Choose a base branch
from
darc-dkurepa/test-e0dd49ce-205c-403a-9df7-91de7073e960
base: dkurepa/test
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[dkurepa/test] Source code updates from maestro-auth-test/dotnet #10
maestro-local-dev
wants to merge
233
commits into
dkurepa/test
from
darc-dkurepa/test-e0dd49ce-205c-403a-9df7-91de7073e960
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: CyrusNajmabadi <4564579+CyrusNajmabadi@users.noreply.github.com>
This reverts commit 574bbe5.
* Initial plan * Add XML doc comments to Incremental Generator public API Co-authored-by: timheuer <4821+timheuer@users.noreply.github.com> * Fix doc comment for Select method on IncrementalValueProvider Co-authored-by: timheuer <4821+timheuer@users.noreply.github.com> * Clarify Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Add clarifying sentences to Select and SelectMany overloads Co-authored-by: jjonescz <3669664+jjonescz@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: timheuer <4821+timheuer@users.noreply.github.com> Co-authored-by: Jan Jones <janjones@microsoft.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: jjonescz <3669664+jjonescz@users.noreply.github.com>
…ilation state. (dotnet#80600) Related to dotnet#80405.
I see the copilot generated commands come at the beginning of a line followed by a description. Update the formatting to match. Adds a comment about how to avoid a design-time build when using dotnet-format.
Co-authored-by: CyrusNajmabadi <4564579+CyrusNajmabadi@users.noreply.github.com>
Co-authored-by: CyrusNajmabadi <4564579+CyrusNajmabadi@users.noreply.github.com>
Co-authored-by: CyrusNajmabadi <4564579+CyrusNajmabadi@users.noreply.github.com>
Co-authored-by: Joey Robichaud <joseph.robichaud@microsoft.com>
Without specifying the xcopy-msbuild version explicitly it is inferred from the tools.vs.version. This does not work because there is not 17.14.0 package on the dotnet-eng feed. Setting this to explicitly be the 17.14.x version that is available from the feed.
…tnet#80483) * Implement * Fix CSharpResources.resx * Remove unnecessary check * Fix unit tests, Fix typo * Fix for runtime with covariant return support * Update src/Compilers/CSharp/Portable/CSharpResources.resx Co-authored-by: Jan Jones <jan.jones.cz@gmail.com> * Update src/Compilers/CSharp/Portable/Symbols/TypeSymbolExtensions.cs Co-authored-by: Jan Jones <jan.jones.cz@gmail.com> * Track result in predicate instead * Fix xlf files * Address pr review * Fix checks * Fix again * Update src/Compilers/CSharp/Portable/Symbols/Source/SourceNamedTypeSymbol_Bases.cs Co-authored-by: Rikki Gibson <rikkigibson@gmail.com> * Fix pr changes * Update src/Compilers/CSharp/Portable/Symbols/Source/SourceNamedTypeSymbol_Bases.cs * Fix error code * Change error code * Fix resources --------- Co-authored-by: Stephan Bauer <stephan.bauer@arcanix.at> Co-authored-by: Jan Jones <jan.jones.cz@gmail.com> Co-authored-by: Rikki Gibson <rikkigibson@gmail.com>
…eHeader Co-authored-by: CyrusNajmabadi <4564579+CyrusNajmabadi@users.noreply.github.com>
…peParameterTypeSymbol.vb
…Editor Added handling for SyntaxKind.DelegateDeclaration in AsInterfaceMember method. Co-authored-by: CyrusNajmabadi <4564579+CyrusNajmabadi@users.noreply.github.com>
Updated to use WithModifiers(default) to strip modifiers, consistent with other member types. Co-authored-by: CyrusNajmabadi <4564579+CyrusNajmabadi@users.noreply.github.com>
Added WorkItem(78860) attribute to TestInsertDelegateIntoInterface test. Updated copilot-instructions.md to include guidance about adding WorkItem attributes for issue fixes. Co-authored-by: CyrusNajmabadi <4564579+CyrusNajmabadi@users.noreply.github.com>
Co-authored-by: Joey Robichaud <joseph.robichaud@microsoft.com>
Co-authored-by: CyrusNajmabadi <4564579+CyrusNajmabadi@users.noreply.github.com>
Co-authored-by: CyrusNajmabadi <4564579+CyrusNajmabadi@users.noreply.github.com>
Co-authored-by: CyrusNajmabadi <4564579+CyrusNajmabadi@users.noreply.github.com>
Co-authored-by: CyrusNajmabadi <4564579+CyrusNajmabadi@users.noreply.github.com>
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com> Co-authored-by: Djuradj Kurepa <dkurepa@microsoft.com>
…build 1001 Updated Dependencies: System.CommandLine (Version 2.0.0-rc.1.25515.110 -> 2.0.0-rc.1.25510.104)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
This is a codeflow update. It may contain both source code changes from the VMR as well as dependency updates. Learn more here.
This pull request brings the following source code changes
From https://github.com/maestro-auth-test/dotnet
Updated Dependencies