Skip to content
This repository has been archived by the owner on Apr 29, 2019. It is now read-only.

Cleanup History file #122

Closed
dmanners opened this issue Oct 25, 2018 · 1 comment
Closed

Cleanup History file #122

dmanners opened this issue Oct 25, 2018 · 1 comment
Labels
good first issue help wanted

Comments

@dmanners
Copy link
Contributor

Preconditions (*)

  1. 2.3-develop
  2. phpstan installed composer require --dev phpstan/phpstan

Steps to reproduce (*)

  1. run ./vendor/bin/phpstan analyse -l 0 app/code/Magento/ImportExport/Model/History.php

Expected result (*)

  1. No errors

Actual result (*)

 1/1 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%

 ------ -------------------------------------------------------------------------------
  Line   History.php
 ------ -------------------------------------------------------------------------------
  66     Access to an undefined property Magento\ImportExport\Model\History::$session.
  313    Access to an undefined property Magento\ImportExport\Model\History::$session.
  314    Access to an undefined property Magento\ImportExport\Model\History::$session.
 ------ -------------------------------------------------------------------------------


 [ERROR] Found 3 errors
@denispapec denispapec mentioned this issue Oct 28, 2018
Merged
4 tasks
dmanners added a commit to denispapec/import-export-improvements that referenced this issue Nov 5, 2018
@dmanners
magento-engcom#122: Update History file for phpstyle check
322d82b
@dmanners
Copy link
Contributor Author

Covered by PR #150

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
good first issue help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dmanners