Skip to content
This repository has been archived by the owner on Apr 29, 2019. It is now read-only.

Define $session property in History model #150

Conversation

denispapec
Copy link
Contributor

Description (*)

  • this PR solves phpstan error by having $session property defined.

Fixed Issues (if relevant)

  1. Cleanup History file #122: Cleanup History file

Manual testing scenarios (*)

  1. run ./vendor/bin/phpstan analyse -l 0 app/code/Magento/ImportExport/Model/History.php
  2. Expected result: no errors.

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@dmanners
Copy link
Contributor

Hello, thank you for your pull request. I will start to process this PR and get back to you if I need any more information.

dmanners
dmanners previously approved these changes Oct 30, 2018
@dmanners dmanners changed the title Define $session property Define $session property in History model Nov 5, 2018
@magento-engcom-team magento-engcom-team merged commit 322d82b into magento-engcom:2.3-develop Nov 29, 2018
@dmanners dmanners mentioned this pull request Nov 30, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants