Skip to content
This repository was archived by the owner on Apr 29, 2019. It is now read-only.

Update zend-mail #12

Closed
buskamuza opened this issue Dec 26, 2017 · 2 comments
Closed

Update zend-mail #12

buskamuza opened this issue Dec 26, 2017 · 2 comments
Assignees
@cieslix
Labels
3rd-party dependency backward-incompatible fixed-in-libs-upgrade help wanted php-7.2 PHP 7.2 support requires-ee-changes
Milestone
Magento 2.3.0

Comments

@buskamuza
Copy link
Contributor

buskamuza commented Dec 26, 2017 •
edited
Loading

Important: Use libs-upgrade branch as base for this task and as target for the PR.

Issues found in zend-mail:

  1. INTL_IDNA_VARIANT_2003 is deprecated, and used as default value for idn_to_ascii() and idn_to_utf8(). See http://php.net/manual/en/migration72.deprecated.php for details.
    \Zend\Mail\Header\AbstractAddressList::idnToAscii() uses idn_to_ascii() with the default value. Explicit value INTL_IDNA_VARIANT_UTS46 should be used as $variant. There is a PR to fix it - Add PHP 7.2 support zendframework/zend-mail#189
  2. Usage of deprecated $errcontext parameter - create PR to the zend-mail repo

A use case to test: create a customer from the store front. Currently it fails with:

Deprecated Functionality: idn_to_ascii(): INTL_IDNA_VARIANT_2003 is deprecated in /private/var/www/htdocs/m2-php72/magento2ce/vendor/zendframework/zend-mail/src/Header/AbstractAddressList.php on line 105 {"exception":"[object] (Magento\\Framework\\Exception\\MailException(code: 0): Deprecated Functionality: idn_to_ascii(): INTL_IDNA_VARIANT_2003 is deprecated in /private/var/www/htdocs/m2-php72/magento2ce/vendor/zendframework/zend-mail/src/Header/AbstractAddressList.php on line 105 at /private/var/www/htdocs/m2-php72/magento2ce/app/code/Magento/Email/Model/Transport.php:87, Exception(code: 0): Deprecated Functionality: idn_to_ascii(): INTL_IDNA_VARIANT_2003 is deprecated in /private/var/www/htdocs/m2-php72/magento2ce/vendor/zendframework/zend-mail/src/Header/AbstractAddressList.php on line 105 at /private/var/www/htdocs/m2-php72/magento2ce/lib/internal/Magento/Framework/App/ErrorHandler.php:61)"} []

Solution: update to ver. 2.9.0
@buskamuza
Copy link
Contributor Author

Should be resolved in scope of #24

@buskamuza buskamuza changed the title Deprecated INTL_IDNA_VARIANT_2003 in zend-mail Update zend-mail Feb 8, 2018
@buskamuza buskamuza reopened this Feb 8, 2018
@buskamuza buskamuza mentioned this issue Feb 8, 2018
Closed
@buskamuza buskamuza added this to the Magento 2.3.0 milestone Mar 6, 2018
@buskamuza buskamuza added help wanted php-7.2 PHP 7.2 support labels Mar 22, 2018
@cieslix cieslix self-assigned this Mar 24, 2018
@cieslix
Copy link
Contributor

cieslix commented Mar 24, 2018

I am closing this issue as I could not reproduce the problem as part of #distributed-cd.

Environment:

  • Magento 2.3-develop,
  • PHP 7.2.3,
  • deploy mode set to developer

Steps:

  • create account on storefront there was no error and email was correctly send,
  • create new customer in admin panel there was no error and email was correctly send,

@cieslix cieslix closed this as completed Mar 24, 2018
@buskamuza buskamuza reopened this Mar 29, 2018
magento-engcom-team added a commit that referenced this issue May 22, 2018
@magento-engcom-team
ENGCOM-1635: GraphQL - Added sort by options to Products GraphQL type #…
2633e5a 
…12

 - Merge Pull Request magento/graphql-ce#12 from zbigniewkuras/graphql-ce:issiue-3
 - Merged commits:
   1. dd3aa38
   2. 02d6a22
   3. 9035d29
   4. d804bab
   5. 9962c66
   6. 1855062
magento-engcom-team pushed a commit that referenced this issue May 22, 2018
ENGCOM-1635: GraphQL - Added sort by options to Products GraphQL type #…
e1e3fc8 
…12
magento-engcom-team pushed a commit that referenced this issue May 22, 2018
@paliarush
ENGCOM-1635: GraphQL - Added sort by options to Products GraphQL type #…
2a504ce 
…12
magento-engcom-team pushed a commit that referenced this issue Jun 15, 2018
@hitesh-wagento
Merge pull request #12 from hitesh-wagento/2.1-develop-PR-port-13930
fc130fd 
[Backport] #13899 Solve Canada Zip Code pattern
magento-engcom-team pushed a commit that referenced this issue Aug 9, 2018
@sanganinamrata
Merge pull request #12 from sanganinamrata/2.3-develop-PR-port-16549
2456027 
[Forwardport] Corrected function comment
magento-engcom-team pushed a commit that referenced this issue Sep 11, 2018
@ronak2ram
Merge pull request #12 from magento/2.3-develop
92c1aa4 
2.3 develop
@srenon srenon mentioned this issue Dec 14, 2018
Closed
@hostep hostep mentioned this issue Dec 19, 2018
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@cieslix cieslix

Labels
3rd-party dependency backward-incompatible fixed-in-libs-upgrade help wanted php-7.2 PHP 7.2 support requires-ee-changes
Projects
None yet
Milestone
Magento 2.3.0
Development

No branches or pull requests
2 participants
@buskamuza @cieslix