3rd-party libraries do not support PHP 7.2

[buskamuza]

List of Libraries to Update

• zendframework/zend-mail - update to ver. 2.9.0. Issue Update zend-mail #12
• zend-soap - ver. 2.7.0 supports PHP 7.2. Issue Update zend-soap #37 to validate usage of the new version.
• pdepend/pdepend - uses deprecated $php_errormsg parameter - used for PHP < 5.3
• squizlabs/php_codesniffer - uses deprecated $php_errormsg parameter - it's in the tests, not used in the executable
• friendsofphp/php-cs-fixer - ver. 2.10.0 supports 7.2. Covered in Update to Symfony 4 #86
• [done] pelago/emogrifier - ver. 2.0.0 supports 7.2. Issue pelago/emogrifier does not support PHP 7.2 #3 to validate.
• [done] colinmollenhour/php-redis-session-abstract - ver. 1.3.8 supports PHP 7.2. Issue colinmollenhour/php-redis-session-abstract does not support PHP 7.2 #1 to validate.
• [done] sjparkinson/static-review - remove. Remove sjparkinson/static-review #40
• colinmollenhour/cache-backend-file - update tp ver. 1.4.1. Issue Update colinmollenhour/cache-backend-file #88

Solution:

• Create PRs to the libs that still have issues. Wait for them being merged and new version released. Depend on the new version.
• Update dependencies to new versions that support PHP 7.2 (see versions mentioned in the list above)

Acceptance Criteria

• composer update passes

In scope of this task, update composer.json and composer.lock, so that composer install passes. Any issues in the code to be reviewed and solved in related tasks for each library.

Use this branch for PRs - https://github.com/magento-engcom/php-7.2-support/tree/libs-upgrade

Related Issues

• magento/zf1 does not support PHP 7.2 #22
• magento/composer does not support PHP 7.2 #2

[buskamuza]

colinmollenhour/php-redis-session-abstract#22

[joshuaadickerson]

Zend-mail issue already created for 7.2 support: zendframework/zend-mail#177

[buskamuza]

From today's meeting:

• move PHP 7.2 to "require" section
• drop PHP 7.0
  • ensure no internal builds are running on PHP 7.0
  • requires https://app.zenhub.com/workspace/o/magento-engcom/php-7.2-support/issues/25
• updated to latest versions of libs

[RomaSlobodeniuk]

Hi, right from "event-chernivtsi-cd" I've found several places incompatible with php7.2, the first is vendor/colinmollenhour/cache-backend-file/File.php:81 uses "each()" function. Also magento uses the last version of this library (1.4):

[RomaSlobodeniuk]

/vendor/magento/zendframework1/library/Zend/Cache/Backend.php:79 - here's a similar problem related to deprecated function "each()".

[pmclain]

Regarding colinmollenhour/cache-backend-file: There are two commits in the source repository removing the each method calls:
colinmollenhour/Cm_Cache_Backend_File@e8d1e38
colinmollenhour/Cm_Cache_Backend_File@161f8ca

I commented on colinmollenhour/Cm_Cache_Backend_File#26 asking about tagging a release including those commits. I'd prefer that over referencing a commit in composer.json

[Ocramius]

@buskamuza zend-mail got a 2.9.0 release with PHP 7.2 compat.