Skip to content
This repository has been archived by the owner on Apr 29, 2019. It is now read-only.

Removed sjparkinson/static-review #84

Closed
wants to merge 1 commit into from
Closed

Removed sjparkinson/static-review #84

wants to merge 1 commit into from

Conversation

RomaSlobodeniuk
Copy link
Contributor

@RomaSlobodeniuk RomaSlobodeniuk commented Feb 17, 2018 •
edited by buskamuza
Loading

Removed sjparkinson/static-review

Description

Removed usage of sjparkinson/static-review in code

Fixed Issues (if relevant)

  1. Remove sjparkinson/static-review #40: Remove sjparkinson/static-review

Manual testing scenarios

None

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@buskamuza
Copy link
Contributor

buskamuza commented Feb 21, 2018 •
edited
Loading

The changes look good. Thanks for the contribution.
Would you be able to redo PR into 2.3-develop branch? libs-composer-update is an experimental branch and won't be merged to the mainline soon.

Update: created #85

@buskamuza buskamuza changed the base branch from libs-composer-update to 2.3-develop February 21, 2018 06:38
@buskamuza buskamuza changed the base branch from 2.3-develop to libs-composer-update February 21, 2018 06:43
@buskamuza buskamuza closed this Feb 21, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@buskamuza buskamuza buskamuza approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RomaSlobodeniuk @buskamuza