Skip to content
This repository has been archived by the owner on Apr 29, 2019. It is now read-only.

Removed sjparkinson/static-review #85

Merged
merged 4 commits into from
Feb 27, 2018
Merged

Removed sjparkinson/static-review #85

merged 4 commits into from
Feb 27, 2018

Conversation

buskamuza
Copy link
Contributor

Removed sjparkinson/static-review

Description

Removed usage of sjparkinson/static-review in code

Fixed Issues (if relevant)

  1. Remove sjparkinson/static-review #40: Remove sjparkinson/static-review

Manual testing scenarios

None

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@buskamuza buskamuza mentioned this pull request Feb 21, 2018
Closed
4 tasks
@magento-engcom-team magento-engcom-team added this to the February 2018 milestone Feb 21, 2018
@magento-engcom-team
MAGETWO-88148: Removed sjparkinson/static-review #85
32c2ebd 
 - Merge Pull Request #85 from magento-engcom/php-7.2-support:remove-sjparkinson-static-review
 - Merged commits:
   1. f7ac9b2
@magento-engcom-team
Copy link
Collaborator

@buskamuza thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository.

giabmf11
giabmf11 reviewed Feb 21, 2018
View reviewed changes
.php_cs.dist Outdated
/**
* Pre-commit hook installation:
* vendor/bin/static-review.php hook:install dev/tools/Magento/Tools/StaticReview/pre-commit .git/hooks/pre-commit
*/
$finder = PhpCsFixer\Finder::create()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a DocBlock. http://devdocs.magento.com/guides/v2.2/coding-standards/docblock-standard-general.html

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added.

@magento-engcom-team magento-engcom-team merged commit 3447bb7 into 2.3-develop Feb 27, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@giabmf11 giabmf11 giabmf11 approved these changes

Assignees

@buskamuza buskamuza

Labels
2.3-develop
Projects
None yet
Milestone
February 2018
Development

Successfully merging this pull request may close these issues.
4 participants
@buskamuza @magento-engcom-team @giabmf11 @RomaSlobodeniuk