Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Order Details for Venia (PWA) #350

Closed
6 tasks
ericerway opened this issue Oct 11, 2018 · 14 comments
Closed
6 tasks

Implement Order Details for Venia (PWA) #350

ericerway opened this issue Oct 11, 2018 · 14 comments

Comments

@ericerway
Copy link

ericerway commented Oct 11, 2018

This issue is for the following packages:

[X] venia-concept
[ ] pwa-buildpack
[X] peregrine
[ ] pwa-module
[ ] pwa-devdocs

Description

https://magento.invisionapp.com/d/main#/console/14921712/324119966/preview

image

image

As a shopper, I want to view details from an order placed on Venia so that I can buy again, share or review item in the future.

  • All products associated with order (ID#)
  • Product details with each item (name, details, quantity, unit price)
  • Actions associated by item (buy again, share item)
  • Details of order (number, date, total and # products)

Assumptions

  • Dependent on Purchase History experience (complete)
  • Reviews will be considered in the future; Ratings API needed
  • Track Order will be considered in the future
  • Buy again will be targeted at the item level not order (B2B in future)

Tasks

@ericerway ericerway changed the title Implement Search auto-complete for Venia (PWA) Implement Order Details for Venia (PWA) Oct 11, 2018
@ericerway
Copy link
Author

Kamino cloned this issue to magento-research/pwa-studio

@ericerway
Copy link
Author

Related to #294 - candidate for next sprint.

@ericerway ericerway added this to the Sprint 28 milestone Oct 23, 2018
@Starotitorov
Copy link
Contributor

@ericerway, We will not be able to estimate this story for now. According to requirements we need to fetch order details and order summary for guest users, but right now Magento allows to retrieve information about order only for authorized users. I have already discussed this question with @zetlen previously and he confirmed this fact.

Right now we can implement only static markup and styling for the story.
Frontend tasks:

  1. Implement common button group component 1SP.
  2. Implement details block 1SP.
  3. Implement order item component 2SP.
  4. Implement order items list component 1SP.
  5. Implement page component 1SP.
  6. Unit tests 3SP.
  7. Documentation 1SP.

Additionally we need to integrate this page with our application, but we can not do this right now because of the issue I described above. This task require additional effort and we can not measure the effort now.

@ericerway, also we have several questions for you:

  1. Do we need to implement only for guest user role? In case we need to support authorized user role as well this will highly affect estimates.
  2. Please, provide detailed description of 'Buy again' button behavior.
  3. Please, provide detailed description of 'Share' button behavior.

@ericerway
Copy link
Author

@Starotitorov OK, let's focus on static markup now and come back around for live data after reviewing the endpoints. Order details is a priority for MVP. Buy again would add the items from the order to the Shopping Cart and Share can be a simple hyperlink to the Product Details page for that item. Thanks!

@Starotitorov
Copy link
Contributor

@ericerway, thank you for the response! So, what should happen when user clicks share button?

@ericerway
Copy link
Author

For MVP it should link to a Product Details page for the item itself. Nothing complex.

@Starotitorov
Copy link
Contributor

Starotitorov commented Oct 26, 2018

Frontend tasks:

  • Implement common button group component.
  • Implement details block.
  • Implement order item component.
  • Implement order items list component.
  • Implement page component.
  • Unit tests.
  • Documentation.

@AlexeyKaryka
Copy link
Contributor

@soumya-ashok Could you please take a look at comments I've left at invision?

@vitalics
Copy link
Contributor

@awilcoxa @ddzhura tests are ready to review and available from the link below:
https://app.hiptest.com/l/sc/2359525

@soumya-ashok
Copy link

@AlexeyKaryka I apologize for the delay in responding to this issue, but I left responses to your Invision comments a couple of days ago. Please let me know if you want to discuss further.

@ericerway
Copy link
Author

Moving to Sprint 30 for review while fetch endpoints are explored.

@ericerway ericerway modified the milestones: Sprint 29, Sprint 30 Nov 19, 2018
@ericerway ericerway removed this from the Sprint 30 milestone Dec 3, 2018
@awilcoxa awilcoxa added the hold On hold until another condition is fulfilled. label Feb 6, 2019
@awilcoxa awilcoxa removed the hold On hold until another condition is fulfilled. label Feb 19, 2019
@awilcoxa
Copy link

moving to backlog for additional grooming, there are graphql dependencies that must be accounted for.

@awilcoxa awilcoxa removed the sustaining Marked for sustaining development. label Mar 5, 2019
@ericerway
Copy link
Author

Moving back to Grooming for reconsideration; we have commits #526 and #762 to work from with the new GraphQL coverage. /CC @tjwiebell

@awilcoxa
Copy link

awilcoxa commented Feb 3, 2020

Closing as obsolete, new cart/checkout experience accounts for new order summary.

@awilcoxa awilcoxa closed this as completed Feb 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants