-
Notifications
You must be signed in to change notification settings - Fork 687
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feature]: Purchase History for Venia (PWA) #294
Comments
Acceptance criterea
Demo scenario
Q&A 1. What kind of approach we generally use to build/define page URLs? |
|
@dmtrkad Initially, we do all our development in Venia. When we feel personally we have created a component or utility that is useful outside Venia, we can PR it to peregrine. |
Frontend tasks:
|
Scenario is ready for review and available from the link below |
Action plan: Need to localize an issue and update jest config.
|
@ericerway @zetlen purchase history page shows items from completed orders and different orders may contain same items, so should we keep duplicated items from different orders on the purchase history page? |
@dmtrkad this is only for authenticated users; order details is for both authenticated and guest users. Let's create a small user story for the remaining 1SP work here. @AlexeyKaryka yes let's keep duplicated items; this should be an uncommon use case. Thanks! |
@ericerway, right now Magento does not allow us to retrive information about order for guest users. |
Double checked and the endpoint is definitely there for order details but may be for admin only and will not work for cookie auth. Let's handle offline but please double check the new REST API documentation here: https://devdocs.magento.com/redoc/2.3/index.html |
@ericerway, we use header Authorization to attach token to request, we do not use cookies at all, we store this token in localStorage. It is possible to retreive order information only for authorized users. We do not have some kind of authorization token for guest users. |
@zetlen, I faced with an issue, I did not find an endpoint to fetch all items from all orders for customer or at least endpoint to fetch all orders for customer using auth token https://devdocs.magento.com/redoc/2.3/ https://devdocs.magento.com/guides/v2.3/rest/list.html . Do we have an appropriate endpoint in Magento to fetch data required for the story? I see that we have an endpoint /V1/orders, but it is for admins. |
@ericerway, @awilcoxa, @zetlen, @jimbo, @dmtrkad We are blocked by issue related to running units tests and importing List from peregrine, there is a pull request #417. Also, there is an open question related to rest API endpoint that can be used to fetch information about items from all orders that were submitted by authorized customer #294 (comment). We have implemented Redux related logic and now there is an open question related to API endpoint to fetch data. |
@ddzhura |
@soumya-ashok, thank you for the feedback! According to requirements filtering is out of the scope of the story and will be implemented in the future. Right now filter field is just a static component. |
@soumya-ashok, @ddzhura, @jimbo I will align filter icon vertically and reduce the size, thank you for the comment.
|
@Starotitorov - The mockups use material icons, but @jimbo and I decided to go with Feather icons because they are open source and suit the design a little better. The feather filter icon is fine the way you have it right now unless there is a "filled" option available in the same library. |
@soumya-ashok, there is no problem to change a color of the icon, yeah, i will do it. |
Moving to Sprint 30 for review while fetch endpoints are explored. |
@jimbo is purchase history merged/released? Anything left to do for this issue? |
Components exist but is not available in UI, moving back to backlog to determine next steps/stories. |
Its better to add item status in the grid ,for example delivered on 12th May 2019 , cancelled,returned etc, |
This is outdated. We have internal work to address the order history page now, starting with #2611 |
This issue is for the following packages:
[X]
venia-concept
[ ]
pwa-buildpack
[X]
peregrine
[ ]
pwa-module
[ ]
pwa-devdocs
Description
(link from Invision to Purchase History; related to account/auth work)
As a shopper, I want to find previous purchases (by item) on Venia by order# so that I can make a repeat purchase or request help from Customer Service.
Assumptions
Tasks
The text was updated successfully, but these errors were encountered: