September 25, 2019

[tariqjawed83]

Please add your topic as a comment to the issue. Use following format:
Topic description and link to PR, if any (duration in min)

Time: 10:30am CST/CDT

BlueJeans Meeting - https://bluejeans.com/7385677850

🎥 Recording

[ihor-sviziev]

Would like to discuss following issue, but not sure if I could join
I tried to highlight it in issue description, so actually it could be discussed without me

Deprecate result factories in favor of one generic magento/magento2#24711

[lenaorobei]

• No imports from static tests namespaces [New Rule] No imports from static tests namespaces magento-coding-standard#142
• Do not use in_array [New rule] Do not use in_array magento-coding-standard#143

[AlexMaxHorkun]

BatchResolverInterface for GraphQL #293 (15 min)

[melnikovi]

Compatibility of declarative schema with different databases #264 15 min
Backwards compatibility policy for JavaScript 10 min

[paliarush]

Multi-device support for customer cart in GraphQL #288 5 min

[buskamuza]

• No imports from static tests namespaces
  • @buskamuza : maybe prohibit any Tests import in application files?
• Do not use in_array
  • @AlexMaxHorkun : what to do with arrays of objects?
  • @buskamuza : we need measurements (including time and memory consumption). Maybe it should be just a recommendation
• Deprecate result factories in favor of one generic
  • @buskamuza : generic factory doesn't declare return type (it's generic).
  • With good objects decomposition for action controllers it should not be a problem to inject a specific factory because only one type of result factory should be needed
  • @buskamuza : from described options, option 1 (inject factory in constructor) should be a recommended way
  • @paliarush : some of the result factories are auto-generated, so we can't deprecated them
• BatchResolverInterface for GraphQL
  • Looks interesting. Let's review the proposal and the prototype offline
• Remove from JS BC guidelines: "Changed event ordering" as a MAJOR change.
  • @paliarush : it would be good to look at examples. Maybe there use cases where changing order of events is a breaking change
  • @buskamuza : ok to remove, but let's sync with @DrewML and author of the item
• Compatibility of declarative schema with different databases
  • @akaplya : to review the proposal, add link to schema standard, propose changes to the interface or describe vision for new interfaces
  • @buskamuza : cover BC question. Describe how places that use current DB adapter should be changed (if they need to).
  • @paliarush : make proposal more generic, not only about declarative schema?