Graphql batch resolver #293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 24, 2019 20:08
Closed
|
I've added batch resolvers that contact a service contract via RESTful API to demonstrate batch resolving for distributed setup |
paliarush
reviewed
Oct 15, 2019
added 3 commits
October 23, 2019 13:47
paliarush
reviewed
Oct 24, 2019
| /** | ||
| * @return array|null | ||
| */ | ||
| public function getValue(): ?array; |
There was a problem hiding this comment.
Please add comprehensive description to the getters.
| /** | ||
| * Resolve multiple brunches/leaves by executing a batch service contract. | ||
| */ | ||
| interface BatchContractResolverInterface |
There was a problem hiding this comment.
I believe the following change makes sense
Suggested change
| interface BatchContractResolverInterface | |
| interface BatchServiceContractResolverInterface |
| * @return object | ||
| * @throws GraphQlInputException | ||
| */ | ||
| public function convertToArgument(ResolveRequestInterface $request); |
There was a problem hiding this comment.
How about
Suggested change
| public function convertToArgument(ResolveRequestInterface $request); | |
| public function prepareRequest(ResolveRequestInterface $request); |
There was a problem hiding this comment.
we don't usually use request with regard to class/service contract arguments. prepareArgument perhaps?
Co-Authored-By: Alex Paliarush <paliarus@adobe.com>
… graphql-batch-resolver
…rkun/architecture into graphql-batch-resolver
paliarush
reviewed
Oct 24, 2019
| * @return ResolveInfo | ||
| */ | ||
| public function getInfo(): ResolveInfo; | ||
|
|
||
| /** | ||
| * Data passed from upper resolvers. |
There was a problem hiding this comment.
From the parent resolver
paliarush
approved these changes
Oct 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Current ResolverInterface does provide tools nor steer developers into creation of fast batch resolvers. By introducing new BatchResolverInterface developers will receive an array of values and arguments to resolve data for in optimal never without requiring them to mess with callbacks
and duplicated values and arguments gathering and promises management logic.
Solution
Introduce BatchResolverInterface, manage promises and create batches of values and arguments on
framework level. Deprecate existing interface
Requested Reviewers
@paliarush