Product and category events contain changed attributes #274

aleksejsbaranovs10 · 2020-09-01T12:38:47Z

Description (*)

Related Pull Requests

https://github.com/magento/saas-export/pull/110
https://github.com/magento/partners-magento2-infrastructure/pull/44

Proto: https://git.corp.adobe.com/ecp/api-protos/pull/16

Fixed Issues (if relevant)

Resolves [Spike] Product and category events contain changed attributes #41

Questions or comments

Code Review Checklist (*)

See dataied checklist

Story AC is completed
proposed changes correspond to Magento Technical Vision
new or changed code is covered with web-api/integration tests (if applicable)
- expected results in test verified with data from fixture
no backward incompatibile changes
Export API (et_schema.xml) and SF API schemas (proto schema) are reflected in the codebase
- prerequisite: story branch created with all needed generated classes according to proposes schema-changes
- DTO classes do not contain any manual changes (Magento\CatalogExportApi*, Magento\CatalogStorefrontApi*)
Class usage: magento/catalog-storefront repo don't use directly classes from magento/saas-export repo and vise-verse
- Check composer.json dependencies
Legacy code is deleted
- Any Data Providers present in Connector part (Magento\CatalogStorefrontConnector, Magento*Extractor modules)
- And Data Providers from Export API (magento/saas-export repo) that is not relevant anymore
- Any DTO for Export API/SF API which does not reflect current schema: et_schema, proto schema
- Any “mapper” on Message Broker (between Export API and SF API)
  - if mapper still needed, verify fields used in mapping, remove not relevant fields

- Separate attributes and store views processing

- Sync command fix

- Doc blocks

- Required attributes change - Sync command fix

aleksejsbaranovs10 · 2020-09-01T13:57:14Z

@magento run Static Tests, Integration Tests

…nt-ce into story-41-changed-attributes

…alog-storefront-ce into story-41-changed-attributes

- Move export-api related code to saas-export repo

aleksejsbaranovs10 · 2020-09-02T13:50:54Z

@magento run Static Tests, Integration Tests

…nt-ce into story-41-changed-attributes

- Static tests fix

aleksejsbaranovs10 · 2020-09-03T10:49:40Z

@magento run Static Tests, Integration Tests

aleksejsbaranovs10 · 2020-09-03T14:21:27Z

@magento run Static Tests

- Typo fix

- Reformatting

-- move framework logic to saas-export

…nt-ce into story-41-changed-attributes

-- move framework logic to saas-export

…o story-41-changed-attributes

- Static tests fix

…nt-ce into story-41-changed-attributes

mslabko · 2020-09-22T21:42:17Z

app/code/Magento/CatalogStorefrontApi/Api/Data/ImportProductRequestAttributesInterface.php

+ *
+ * @SuppressWarnings(PHPMD.BooleanGetMethodName)
+ */
+interface ImportProductRequestAttributesInterface


@aleksejsbaranovs10 Did you create this manually?

vgoncharenko · 2020-09-23T20:19:40Z

Autogenerated code has to be autogenerated. If you have api-proto related PR already, please mention it in a description, but not under 'Related Pull Requests' section

vgoncharenko · 2020-09-23T20:20:47Z

Please, check if all of the changes in PRs to magento EE and SaaS-export is related to this task

app/code/Magento/CatalogMessageBroker/Model/DataMapper/ConfigurableOptions.php

app/code/Magento/CatalogMessageBroker/Model/FetchCategories.php

app/code/Magento/CatalogMessageBroker/Model/MessageBus/Category/PublishCategoriesConsumer.php

app/code/Magento/CatalogMessageBroker/Model/MessageBus/Product/PublishProductsConsumer.php

app/code/Magento/CatalogStorefront/Model/Storage/Client/ElasticsearchCommand.php

app/code/Magento/CatalogStorefrontConnector/Command/Sync.php

app/code/Magento/CatalogStorefrontConnector/Model/CategoriesQueueConsumer.php

app/code/Magento/CatalogStorefrontConnector/Model/ProductsQueueConsumer.php

…nt-ce into story-41-changed-attributes

- Code clean-up

- Revert manually changed proto files

aleksejsbaranovs10 · 2020-09-29T14:03:15Z

Proto files to generate -> https://github.com/magento/catalog-storefront/pull/274/files#diff-86c4774dda7053a77808c90e4c429f25

aleksejsbaranovs10 · 2020-09-29T14:06:35Z

@magento run Static Tests

- Code clean-up

app/code/Magento/CatalogMessageBroker/Model/MessageBus/Category/PublishCategoriesConsumer.php

app/code/Magento/CatalogMessageBroker/Model/MessageBus/Product/PublishProductsConsumer.php

vgoncharenko

request one change

- Code clean-up

aleksejsbaranovs10 · 2020-09-30T15:58:03Z

@magento run all tests

…nt-ce into story-41-changed-attributes

- Static tests fix

aleksejsbaranovs10 · 2020-10-01T12:01:23Z

@magento run all tests

…nt-ce into story-41-changed-attributes

- Static test fix

aleksejsbaranovs10 · 2020-10-02T10:29:02Z

@magento run Integration Tests, Static Tests

- Magento health index fix

aleksejsbaranovs10 · 2020-10-02T14:34:57Z

@magento run all tests

- Magento health index fix

aleksejsbaranovs10 · 2020-10-02T14:37:48Z

@magento run all tests

vgoncharenko · 2020-10-05T18:39:29Z

@magento run Static Tests

aleksejsbaranovs added 4 commits September 1, 2020 15:36

Product and category events contain changed attributes

e82a222

- Separate attributes and store views processing

Product and category events contain changed attributes

8036584

- Sync command fix

Product and category events contain changed attributes

a7515bb

- Doc blocks

Product and category events contain changed attributes

c9aea13

- Required attributes change - Sync command fix

aleksejsbaranovs added 3 commits September 2, 2020 13:14

Merge branch 'develop' of https://github.com/magento/catalog-storefro…

6fa2383

…nt-ce into story-41-changed-attributes

Merge branch 'story-185-export-api' of https://github.com/magento/cat…

168a144

…alog-storefront-ce into story-41-changed-attributes

Product and category events contain changed attributes

ff6e4db

- Move export-api related code to saas-export repo

aleksejsbaranovs10 changed the base branch from develop to story-185-export-api September 2, 2020 13:43

le0n4ik changed the base branch from story-185-export-api to develop September 2, 2020 18:50

aleksejsbaranovs added 2 commits September 3, 2020 13:06

Merge branch 'develop' of https://github.com/magento/catalog-storefro…

07e4a14

…nt-ce into story-41-changed-attributes

Product and category events contain changed attributes

f7027f0

- Static tests fix

aleksejsbaranovs and others added 8 commits September 4, 2020 17:54

Product and category events contain changed attributes

13b29ca

- Typo fix

Product and category events contain changed attributes

ad11c11

- Reformatting

Mview patch update

341462c

-- move framework logic to saas-export

Merge branch 'develop' of https://github.com/magento/catalog-storefro…

3f483e5

…nt-ce into story-41-changed-attributes

Mview patch update

24815e9

-- move framework logic to saas-export

Merge remote-tracking branch 'origin/story-41-changed-attributes' int…

a8c374e

…o story-41-changed-attributes

Mview patch update

63b9a7a

- Static tests fix

Merge branch 'develop' of https://github.com/magento/catalog-storefro…

63029a8

…nt-ce into story-41-changed-attributes

skovalenk linked an issue Sep 21, 2020 that may be closed by this pull request

[Spike] Product and category events contain store view ids #40

Closed

mslabko reviewed Sep 22, 2020

View reviewed changes

vgoncharenko suggested changes Sep 23, 2020

View reviewed changes

aleksejsbaranovs added 2 commits September 24, 2020 13:26

Merge branch 'develop' of https://github.com/magento/catalog-storefro…

8c072d2

…nt-ce into story-41-changed-attributes

Merge branch 'develop' of https://github.com/magento/catalog-storefro…

80dff27

…nt-ce into story-41-changed-attributes

aleksejsbaranovs added 3 commits September 29, 2020 16:53

Product and category events contain changed attributes

db96623

- Code clean-up

Product and category events contain changed attributes

5c67de6

- Revert manually changed proto files

Product and category events contain changed attributes

dbd4447

- Revert manually changed proto files

Product and category events contain changed attributes

65aac6b

- Code clean-up

vgoncharenko reviewed Sep 29, 2020

View reviewed changes

app/code/Magento/CatalogMessageBroker/Model/MessageBus/Category/PublishCategoriesConsumer.php Outdated Show resolved Hide resolved

vgoncharenko reviewed Sep 29, 2020

View reviewed changes

app/code/Magento/CatalogMessageBroker/Model/MessageBus/Product/PublishProductsConsumer.php Outdated Show resolved Hide resolved

vgoncharenko suggested changes Sep 29, 2020

View reviewed changes

aleksejsbaranovs added 2 commits September 30, 2020 15:09

Product and category events contain changed attributes

d15ccab

- Code clean-up

Product and category events contain changed attributes

4c02434

- Code clean-up

vgoncharenko approved these changes Sep 30, 2020

View reviewed changes

generate proto, update copy of proto schema

73b987e

aleksejsbaranovs10 mentioned this pull request Oct 1, 2020

Export api emits changed attributes and runs only required data providers #362

Open

aleksejsbaranovs added 2 commits October 1, 2020 14:53

Merge branch 'develop' of https://github.com/magento/catalog-storefro…

d66a5cf

…nt-ce into story-41-changed-attributes

Product and category events contain changed attributes

42fc760

- Static tests fix

aleksejsbaranovs added 2 commits October 2, 2020 13:14

Merge branch 'develop' of https://github.com/magento/catalog-storefro…

e9eea43

…nt-ce into story-41-changed-attributes

Product and category events contain changed attributes

5ae64a5

- Static test fix

Product and category events contain changed attributes

b7b9f48

- Magento health index fix

Product and category events contain changed attributes

4e25742

- Magento health index fix

vgoncharenko self-assigned this Oct 5, 2020

vgoncharenko merged commit 73e0ab7 into develop Oct 5, 2020

skovalenk mentioned this pull request Oct 6, 2020

40 mview patch update new branch magento/magento2#30086

Closed

4 tasks

mslabko mentioned this pull request Oct 6, 2020

[Spike] Product and category events contain changed attributes #41

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Product and category events contain changed attributes #274

Product and category events contain changed attributes #274

aleksejsbaranovs10 commented Sep 1, 2020 •

edited by vgoncharenko

Loading

aleksejsbaranovs10 commented Sep 1, 2020

aleksejsbaranovs10 commented Sep 2, 2020

aleksejsbaranovs10 commented Sep 3, 2020

aleksejsbaranovs10 commented Sep 3, 2020

mslabko Sep 22, 2020

vgoncharenko commented Sep 23, 2020

vgoncharenko commented Sep 23, 2020

aleksejsbaranovs10 commented Sep 29, 2020

aleksejsbaranovs10 commented Sep 29, 2020

vgoncharenko left a comment

aleksejsbaranovs10 commented Sep 30, 2020

aleksejsbaranovs10 commented Oct 1, 2020

aleksejsbaranovs10 commented Oct 2, 2020

aleksejsbaranovs10 commented Oct 2, 2020

aleksejsbaranovs10 commented Oct 2, 2020

vgoncharenko commented Oct 5, 2020

Product and category events contain changed attributes #274

Product and category events contain changed attributes #274

Conversation

aleksejsbaranovs10 commented Sep 1, 2020 • edited by vgoncharenko Loading

Description (*)

Related Pull Requests

Fixed Issues (if relevant)

Questions or comments

Code Review Checklist (*)

aleksejsbaranovs10 commented Sep 1, 2020

aleksejsbaranovs10 commented Sep 2, 2020

aleksejsbaranovs10 commented Sep 3, 2020

aleksejsbaranovs10 commented Sep 3, 2020

mslabko Sep 22, 2020

Choose a reason for hiding this comment

vgoncharenko commented Sep 23, 2020

vgoncharenko commented Sep 23, 2020

aleksejsbaranovs10 commented Sep 29, 2020

aleksejsbaranovs10 commented Sep 29, 2020

vgoncharenko left a comment

Choose a reason for hiding this comment

aleksejsbaranovs10 commented Sep 30, 2020

aleksejsbaranovs10 commented Oct 1, 2020

aleksejsbaranovs10 commented Oct 2, 2020

aleksejsbaranovs10 commented Oct 2, 2020

aleksejsbaranovs10 commented Oct 2, 2020

vgoncharenko commented Oct 5, 2020

aleksejsbaranovs10 commented Sep 1, 2020 •

edited by vgoncharenko

Loading