Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Variants update in proto scheme #339

Merged
merged 10 commits into from
Sep 28, 2020
Merged

Variants update in proto scheme #339

merged 10 commits into from
Sep 28, 2020

Conversation

RuslanKostiv1
Copy link
Contributor

@RuslanKostiv1 RuslanKostiv1 commented Sep 24, 2020 •
edited by mslabko
Loading

Description (*)

Fixes #327

Related Pull Requests

https://github.com/magento/saas-export/pull/133
https://github.com/magento/partners-magento2-infrastructure/pull/41

proto: https://git.corp.adobe.com/ecp/api-protos/pull/12

Fixed Issues (if relevant)

  1. Fixes magento/catalog-storefront#<issue_number>

Questions or comments

Code Review Checklist (*)

See datailed checklist

  • Story AC is completed
  • proposed changes correspond to Magento Technical Vision
  • new or changed code is covered with web-api/integration tests (if applicable)
    • expected results in test verified with data from fixture
  • no backward incompatible changes
  • Export API (et_schema.xml) and SF API schemas (proto schema) are reflected in the codebase
    • prerequisite: story branch created with all needed generated classes according to proposes schema-changes
    • DTO classes do not contain any manual changes (Magento\CatalogExportApi*, Magento\CatalogStorefrontApi*)
  • Class usage: magento/catalog-storefront repo don't use directly classes from magento/saas-export repo and vise-verse
    • Check composer.json dependencies
  • Legacy code is deleted
    • Any Data Providers present in Connector part (Magento\CatalogStorefrontConnector, Magento*Extractor modules)
    • And Data Providers from Export API (magento/saas-export repo) that is not relevant anymore
    • Any DTO for Export API/SF API which does not reflect current schema: et_schema, proto schema
    • Any “mapper” on Message Broker (between Export API and SF API)
      • if mapper still needed, verify fields used in mapping, remove not relevant fields

@RuslanKostiv1 RuslanKostiv1 changed the title [326.1] Variants update in proto scheme Variants update in proto scheme Sep 24, 2020
@RuslanKostiv1
Copy link
Contributor Author

@magento run all Tests

@RuslanKostiv1
Copy link
Contributor Author

@magento run all tests

@RuslanKostiv1
Copy link
Contributor Author

@magento run all tests

@RuslanKostiv1
Copy link
Contributor Author

@magento run all tests

@RuslanKostiv1
Copy link
Contributor Author

@magento run WebAPI Tests

1 similar comment
@mslabko
Copy link
Member

mslabko commented Sep 28, 2020

@magento run WebAPI Tests

@mslabko
Copy link
Member

mslabko commented Sep 28, 2020

web api for SF API tests are green with https://github.com/magento/partners-magento2-infrastructure/pull/41

@mslabko mslabko merged commit bdeab0c into develop Sep 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[326.1] Variants update in proto scheme
2 participants
@RuslanKostiv1 @mslabko