gift card options bug

[bricht]

Description (*)

Related Pull Requests

https://github.com/magento/saas-export/pull/143
https://github.com/magento/partners-magento2-infrastructure/pull/42

Fixed Issues (if relevant)

1. Fixes [Bug] Add more data to Gift Card options #368

Questions or comments

Code Review Checklist (*)

See dataied checklist

• Story AC is completed
• proposed changes correspond to Magento Technical Vision
• new or changed code is covered with web-api/integration tests (if applicable)
  • expected results in test verified with data from fixture
• no backward incompatibile changes
• Export API (et_schema.xml) and SF API schemas (proto schema) are reflected in the codebase
  • prerequisite: story branch created with all needed generated classes according to proposes schema-changes
  • DTO classes do not contain any manual changes (Magento\CatalogExportApi*, Magento\CatalogStorefrontApi*)
• Class usage: magento/catalog-storefront repo don't use directly classes from magento/saas-export repo and vise-verse
  • Check composer.json dependencies
• Legacy code is deleted
  • Any Data Providers present in Connector part (Magento\CatalogStorefrontConnector, Magento*Extractor modules)
  • And Data Providers from Export API (magento/saas-export repo) that is not relevant anymore
  • Any DTO for Export API/SF API which does not reflect current schema: et_schema, proto schema
  • Any “mapper” on Message Broker (between Export API and SF API)
    • if mapper still needed, verify fields used in mapping, remove not relevant fields

[bricht]

@magento run all tests

[bricht]

@magento run Static Tests

[bricht]

@magento run all tests

[vgoncharenko]

Thank you for your contributio.
Your PR was merged to internal private fork: https://github.com/magento-commerce/catalog-storefront-ce/pull/4