Declare return types to be compatible with composer 2.7+ #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewbess
suggested changes
Feb 14, 2024
There was a problem hiding this comment.
Hello @Seldaek
Thank you for your efforts here.
It looks like we need to fix setApplication method too.
Could you please check it and fix if it is required?
Thank you in advance.
|
Yes that's needed but only when using symfony 7 i think. Anyway i added it for safety |
sidolov
approved these changes
Feb 14, 2024
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Composer 2.7 had to declare the return type for Command::execute() to be compatible with Symfony 7, leading to issues with this plugin composer/composer#11843