Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Declare return types to be compatible with composer 2.7+ #39

Merged
merged 3 commits into from
Feb 14, 2024
Merged

Declare return types to be compatible with composer 2.7+ #39

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a39d2e8
Declare return types to be compatible with composer 2.7+
Seldaek Feb 9, 2024
71a5a1a
Declare return types to be compatible with composer 2.7+
Seldaek Feb 9, 2024
307a56e
Add setApplication return type
Seldaek Feb 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/Magento/ComposerRootUpdatePlugin/Plugin/Commands/OverrideRequireCommand.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ public function setApplication(Application $application = null)
*
* @return void
*/
protected function configure()
protected function configure(): void
{
parent::configure();

Expand Down Expand Up @@ -170,7 +170,7 @@ protected function configure()
*
* @throws Exception
*/
protected function execute(InputInterface $input, OutputInterface $output)
protected function execute(InputInterface $input, OutputInterface $output): int
{
$this->console = new Console($this->getIO(), $input->getOption(self::INTERACTIVE_OPT));
$this->pkgUtils = new PackageUtils($this->console);
Expand Down
4 changes: 2 additions & 2 deletions src/Magento/ComposerRootUpdatePlugin/Plugin/Commands/RequireCommerceCommand.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ class RequireCommerceCommand extends ExtendableRequireCommand
*
* @return void
*/
protected function configure()
protected function configure(): void
{
parent::configure();

Expand Down Expand Up @@ -154,7 +154,7 @@ protected function getFormattedHelp(): string
*
* @throws Exception
*/
protected function execute(InputInterface $input, OutputInterface $output)
protected function execute(InputInterface $input, OutputInterface $output): int
{
$this->console = new Console($this->getIO(), $input->getOption(self::INTERACTIVE_OPT));
$console = $this->console;
Expand Down
Loading