Skip to content
This repository has been archived by the owner on Nov 19, 2024. It is now read-only.

magento/devdocs#: UrlRewrite endpoint #4064

Merged
merged 3 commits into from
Mar 28, 2019

Conversation

atwixfirster
Copy link
Contributor

@atwixfirster atwixfirster commented Mar 27, 2019

Updates to "UrlRewrite endpoint" regarding to Magento2 version 2.3.1.

This PR is a:

  • New topic
  • Content update
  • Content fix or rewrite
  • Bug fix or improvement

Summary

When this pull request is merged, it will fix visual issue on the page "UrlRewrite endpoint"

UrlRewrite_endpoint_01

and updates information about UrlRewrite regarding to Magento2 version 2.3.1.

Additional information

List all affected URLs

Thank you!

@devops-devdocs
Copy link
Collaborator

An admin must run tests on this PR before it can be merged.

@keharper keharper self-assigned this Mar 27, 2019
@keharper
Copy link
Contributor

keharper commented Mar 27, 2019

@atwixfirster The parts about relative_url and canonical_url are not correct for 2.3.1. Those changes appear in the 2.3-develop branch of the graphql-ce repo, but they won't be merged into mainline until 2.3.2. Please back out those changes.

Note: Those changes have been applied to 2.3.2 in the develop branch per #3925

I'm not sure if the url parameter was removed at some time in the past, or if it's there due to some copy/paste mistake, but I verified it's not in the 2.3.1 branch. I'll merge the non relative_url/canonical_url changes you made in this PR.

@keharper keharper added Technical Updates to the code or processes that alter the technical content of the doc xx2.3.1 Magento 2.3.1 changes labels Mar 27, 2019
@atwixfirster
Copy link
Contributor Author

@atwixfirster The parts about relative_url and canonical_url are not correct for 2.3.1.

I am sorry @keharper . I used a wrong branch when wrote about relative_url

😊

@atwixfirster
Copy link
Contributor Author

atwixfirster commented Mar 27, 2019

@keharper , so when this pull request is merged, it will fix a visual issue on the page "UrlRewrite endpoint"

UrlRewrite_endpoint_01

Thank you!

@keharper keharper added Editorial Typo and grammar fixes or minor rewrites to correct inaccuracies and removed Technical Updates to the code or processes that alter the technical content of the doc labels Mar 27, 2019
@keharper
Copy link
Contributor

running tests

@keharper keharper merged commit ca1175b into magento:master Mar 28, 2019
@ghost
Copy link

ghost commented Mar 28, 2019

Hi @atwixfirster, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@keharper
Copy link
Contributor

Thanks, @atwixfirster

@keharper keharper mentioned this pull request Mar 28, 2019
4 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Editorial Typo and grammar fixes or minor rewrites to correct inaccuracies Partner: Atwix partners-contribution PR created by Magento partner xx2.3.1 Magento 2.3.1 changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants