Skip to content
This repository has been archived by the owner on Nov 19, 2024. It is now read-only.

MERGE IN 2.3.2: Fixed table structure with removing space and removed deprecated attribute. #3925

Merged
merged 3 commits into from
Mar 26, 2019
Merged

MERGE IN 2.3.2: Fixed table structure with removing space and removed deprecated attribute. #3925

merged 3 commits into from
Mar 26, 2019

Conversation

mage2pratik
Copy link
Contributor

@mage2pratik mage2pratik commented Mar 13, 2019 •
edited
Loading

This PR is a:

  • New topic
  • Content update
  • Content fix or rewrite
  • Bug fix or improvement

Summary

When this pull request is merged, it will fix table structure and removed deprecated attribute "canonical_url", added "relative_url".

Additional information

Codebase:
https://github.com/magento/graphql-ce/blob/6cc68c64c91aee7bc1f4a66a3892b94843df78a6/app/code/Magento/UrlRewriteGraphQl/etc/schema.graphqls#L10

@magento-cicd2
Copy link
Contributor

An admin must run tests on this PR before it can be merged.

@dobooth dobooth requested a review from erikmarr March 13, 2019 20:36
@erikmarr
Copy link
Contributor

I'd like to get @keharper to take a look at this one as he recently merged in the following PR that reverts relative to canonical:
#3859

I do see the codebase change where the schema was updated, however I'm not seeing that in the latest 2.3.1-release branch.

@erikmarr erikmarr requested a review from keharper March 13, 2019 21:41
@keharper
Copy link
Contributor

GraphQL PR-magento/graphql-ce#398 will be part of 2.3.2. We can't merge it into the 2.3.1-integration branch. Putting this on hold until we have a 2.3.2-integration branch.

@keharper keharper changed the title Fixed table structure with removing space and removed deprecated attribute. MERGE IN 2.3.2: Fixed table structure with removing space and removed deprecated attribute. Mar 18, 2019
@keharper keharper added Technical Updates to the code or processes that alter the technical content of the doc Community Docs impacted by community code contribution xx2.3.2 Magento 2.3.2 changes labels Mar 18, 2019
@keharper keharper changed the base branch from 2.3.1-integration to develop March 26, 2019 16:01
@keharper
update samples
3611334 
I updated the samples to include `relative_url` instead of `canonical_url`. I also made some cosmetic edits.
@keharper keharper merged commit b0803b6 into magento:develop Mar 26, 2019
@ghost
Copy link

ghost commented Mar 26, 2019

Hi @mage2pratik, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@keharper
Copy link
Contributor

Thanks, @mage2pratik I think this is the first 2.3.2 PR.

This was referenced Mar 27, 2019
Closed
Merged
Merged
@mage2pratik mage2pratik deleted the patch-35 branch March 26, 2021 08:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@keharper keharper keharper approved these changes

@erikmarr erikmarr Awaiting requested review from erikmarr

Assignees

@keharper keharper

Labels
Community Docs impacted by community code contribution Partner: Krish TechnoLabs partners-contribution PR created by Magento partner Technical Updates to the code or processes that alter the technical content of the doc xx2.3.2 Magento 2.3.2 changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mage2pratik @magento-cicd2 @erikmarr @keharper @magento-engcom-team