Skip to content
This repository has been archived by the owner on Dec 19, 2019. It is now read-only.

Changed canonical_url to relative_url #398

Conversation

yogeshsuhagiya
Copy link
Member

Description (*)

As per the devdoc, there must be a relative_url instead of canonical_url.

Fixed Issues (if relevant)

  1. N/A

Manual testing scenarios (*)

  1. Try to execute following GraphQl query as explain in docs.
    { urlResolver(url:"joust-duffle-bag.html") { id relative_url type } }
  2. It throws following error:
    { "errors": [ { "message": "Cannot query field \"relative_url\" on type \"EntityUrl\".", "category": "graphql", "locations": [ { "line": 4, "column": 4 } ] } ] }

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-cicd2
Copy link
Contributor

magento-cicd2 commented Feb 25, 2019

CLA assistant check
All committers have signed the CLA.

@yogeshsuhagiya
Copy link
Member Author

Hello @magento-engcom-team, can you please review this PR?

@yogeshsuhagiya yogeshsuhagiya requested review from rogyar and removed request for rogyar March 1, 2019 07:14
@TomashKhamlai TomashKhamlai self-assigned this Mar 1, 2019
@TomashKhamlai
Copy link
Contributor

@yogeshsuhagiya, could you take a look on this #436 ?

@TomashKhamlai TomashKhamlai assigned naydav and unassigned TomashKhamlai Mar 5, 2019
@yogeshsuhagiya
Copy link
Member Author

Hi @TomashKhamlai, checked the issue and it looks good.

@TomashKhamlai
Copy link
Contributor

@yogeshsuhagiya would you like to create a PR for this problem?
There are 2-3 similar problems solved in previous 2 month. Solution is usually as simple as coverage assertions.

@yogeshsuhagiya
Copy link
Member Author

Hi @TomashKhamlai, yes sure. I like to create PR.

@ghost
Copy link

ghost commented Mar 8, 2019

Hi @yogeshsuhagiya, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants