Skip to content
This repository has been archived by the owner on Dec 19, 2019. It is now read-only.

urlResolver support for absolute paths #79

Closed
misha-kotov opened this issue May 23, 2018 · 4 comments
Closed

urlResolver support for absolute paths #79

misha-kotov opened this issue May 23, 2018 · 4 comments

Comments

@misha-kotov
Copy link

misha-kotov commented May 23, 2018

As a Magento Developer, I want urlResolver to support absolute paths in addition to relative so that it's easier for me to pass it URLs without performing additional formatting.

This story is only for the input of the urlResolver query. The output fields will be corrected in the scope of #80

Acceptance Criteria:

@misha-kotov misha-kotov added for-grooming This issue needs to be discussed before it can be worked on urlResolver labels May 23, 2018
@paliarush paliarush added good first issue Good for newcomers small labels May 23, 2018
magento-engcom-team pushed a commit that referenced this issue Aug 27, 2018
MAGETWO-66666: Adding a product to cart from category page with an ex…
@pfantini pfantini self-assigned this Oct 12, 2018
@misha-kotov
Copy link
Author

@naydav @pfantini I updated the description and AC to make this more clear. Let me know if there are any more outstanding questions here.

@naydav
Copy link
Contributor

naydav commented Dec 11, 2018

@misha-kotov

So for example, if we have a request

{
  urlResolver(url:"privacy-policy-cookie-restriction-mode")
  {
   id
   relative_url
   absolute_url 
   type
  }
}

Result should be

{
  "data": {
    "urlResolver": {
      "id": 4,
      "relative_url": "cms/page/view/page_id/4",
      "absolute_url": "http://graphql.local/index.php/cms/page/view/page_id/4",
      "type": "CMS_PAGE"
    }
  }
}

Correct?
But in such a case, I can not get a target_path

@naydav naydav removed for-grooming This issue needs to be discussed before it can be worked on good first issue Good for newcomers small labels Dec 11, 2018
@misha-kotov
Copy link
Author

This story is about the input only. User should be able to pass an absolute url to the resolver as input and get a valid response:

{
  urlResolver(url:"http://magento23.mk/privacy-policy-cookie-restriction-mode/")
  {

@naydav
Copy link
Contributor

naydav commented Mar 8, 2019

#398

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants