Skip to content
This repository has been archived by the owner on Dec 19, 2019. It is now read-only.

GraphQL-79: Absolute and relative path passed as argument return matching fields #208

Closed
wants to merge 4 commits into from
Closed

GraphQL-79: Absolute and relative path passed as argument return matching fields #208

wants to merge 4 commits into from

Conversation

pfantini
Copy link
Contributor

Description

Copy MR#95

Fixed Issues

  1. urlResolver support for absolute paths urlResolver support for absolute paths #79

Manual testing scenarios

  1. Passed absolute and relative paths for CMS, Product and Category pages
  2. Got always same response with the additional absolute_path field

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@naydav naydav changed the title GraphQL-79: Copy MR#95: Absolute and relative path passed as argument return matching fields GraphQL-79: Absolute and relative path passed as argument return matching fields Oct 11, 2018
@pfantini pfantini force-pushed the 80-urlResolver-rename-canonical_url-to-relative_url branch from 47c3611 to 83bc162 Compare October 11, 2018 15:37
@magento-engcom-team magento-engcom-team added this to the Release: 2.3.1 milestone Oct 18, 2018
@naydav naydav mentioned this pull request Nov 13, 2018
Closed
4 tasks
@naydav naydav removed this from the Release: 2.3.1 milestone Dec 7, 2018
@naydav
Copy link
Contributor

naydav commented Apr 3, 2019

Closed due to
#79 (comment)

@pfantini Sorry for a delay with a response, it was because that current milestone is devoted to Checkout workflow and Performance Improvement.

Of course, I will be happy to hear from you "I’ll be back"!

@naydav naydav closed this Apr 3, 2019
@ghost
Copy link

ghost commented Apr 3, 2019

Hi @pfantini, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@naydav naydav

Labels
Partner: Hammer partners-contribution Release Line: 2.3
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pfantini @naydav @magento-engcom-team