This repository has been archived by the owner on Nov 19, 2024. It is now read-only.
[GraphQl] Fixed response for removeCouponFromCart mutation #4318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
magento-engcom-team
added
Partner: Atwix
partners-contribution
4 tasks
|
An admin must run tests on this PR before it can be merged. |
keharper
added
xx2.3.2
|
Fixed under #4502, so this is a duplicate now. |
|
Hi @rogyar, thank you for your contribution! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
This PR introduces a fix for response of removeCouponFromCart mutation documented in https://devdocs.magento.com/guides/v2.3/graphql/reference/quote.html. After coupon is removed from the shopping cart, the response contains no coupon code (currently the response contains the same coupon code that was previously applied).
Affected URLs
https://devdocs.magento.com/guides/v2.3/graphql/reference/quote.html
Links to source code
https://github.com/magento/magento2/blob/1d1c2ea4381bcda5b1baec7360dfc33b0b6569c9/app/code/Magento/QuoteGraphQl/etc/schema.graphqls#L267
The
removeCouponFromCartmutation returnsCarttype which includesapplied_coupontype. If no coupon is applied to the shopping cart theapplied_couponfield of theCartobject isnull