Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft: Reorg GraphQL quote topic #4502

Merged
merged 7 commits into from
May 17, 2019
Merged

Draft: Reorg GraphQL quote topic #4502

merged 7 commits into from
May 17, 2019

Conversation

keharper
Copy link
Contributor

@keharper keharper commented May 13, 2019

Purpose of this pull request

This pull request (PR) updates the GraphQL quote endpoint to include all the 2.3.2 community contributions

Related issue

Affected DevDocs pages

This PR also adds 8 new topics and several include files.

Links to Magento source code

whatsnew
The GraphQL quote endpoint adds numerous mutations for 2.3.2. Each mutation is documented separately. The GraphQL release notes lists these new mutations.

@keharper keharper self-assigned this May 13, 2019
@keharper keharper added xx2.3.2 Magento 2.3.2 changes Community Docs impacted by community code contribution New Topic A major update published as an entirely new document Internal Dev Differentiates work between community and Magento staff labels May 13, 2019
@keharper keharper requested a review from erikmarr May 14, 2019 03:20
@keharper keharper marked this pull request as ready for review May 14, 2019 03:21
@keharper
Copy link
Contributor Author

keharper commented May 14, 2019

Externally-viewable draft. The quote documentation begins here.

https://devdocs.magedevteam.com/424/guides/v2.3/graphql/reference/quote.html

Adding @rogyar as a reviewer as mentioned in #4316 His updated example is here: https://devdocs.magedevteam.com/424/guides/v2.3/graphql/reference/quote-add-simple-products.html

I would appreciate it if @atwixfirster or someone with a good working knowledge of the Quote endpoint reviewed the all the new topics.

Copy link
Contributor

@erikmarr erikmarr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Just some minor editorial feedback.

guides/v2.3/graphql/reference/quote-add-simple-products.md Outdated Show resolved Hide resolved
guides/v2.3/graphql/reference/quote-add-simple-products.md Outdated Show resolved Hide resolved
guides/v2.3/graphql/reference/quote-shipping-method.md Outdated Show resolved Hide resolved
guides/v2.3/graphql/reference/quote-update-cart-items.md Outdated Show resolved Hide resolved
guides/v2.3/graphql/reference/quote-update-cart-items.md Outdated Show resolved Hide resolved
guides/v2.3/graphql/reference/quote-update-cart-items.md Outdated Show resolved Hide resolved
@keharper keharper merged commit b3c7efb into develop May 17, 2019
@ghost
Copy link

ghost commented May 17, 2019

Hi @keharper, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

mutation {
addSimpleProductsToCart(
input: {
cart_id: "IeTUiU0oCXjm0uRqGCOuhQ2AuQatogjG",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

, can be omitted in the request body according to Graphql Docs. It can improve the clearness of the examples.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Community Docs impacted by community code contribution Internal Dev Differentiates work between community and Magento staff New Topic A major update published as an entirely new document xx2.3.2 Magento 2.3.2 changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants