-
Notifications
You must be signed in to change notification settings - Fork 154
Conversation
Hello @osrecio, Thanks for PR, will start a review today! What about another ticket with the scheme fixes? these tickets have top priority due to coming release |
Hi @naydav , For sure, I want to help in this part. It's my "first time" with graphql-ce repo and I want to go step by step. I fixed the tests for this PR, actually I need setup correctly my env to work in right way and be able to launch the tests before creating a PR |
When the tests stop failing I will squash the commits in one or 2 more descriptive. This Weekend I will setup my env to run the tests etc before create PR. |
Thanks. Welcome on board. If you will have some questions, please, ping me in the slack channel |
Rename CartItemQuantityInput by CartItemUpdateQuantityInput Rename CartItemInput by CartItemQuantityInput Adapt tests
I ran my own tests and are ok |
# Conflicts: # app/code/Magento/QuoteGraphQl/Model/Resolver/UpdateCartItems.php
Hi @osrecio, thank you for your contribution! |
Documentation updated in magento/devdocs#4502 |
Fix Quote Schema inconsistency
Description (*)
qty
should be renamedquantity
CartItemQuantityInput
should be renamed toCartItemUpdateQuantityInput
CartItemInput
should be renamed toCartItemQuantityInput
data: CartItemInput!
should be renamed toquantity: CartItemQuantityInput!
Fixed Issues (if relevant)
Contribution checklist (*)