Skip to content
This repository has been archived by the owner on Dec 19, 2019. It is now read-only.

Offline Payment Method Tests #632

Merged

Conversation

pmclain
Copy link
Contributor

@pmclain pmclain commented Apr 25, 2019

Description (*)

Tests for setting offline payment methods as customer and guest.

  • Check Money Order
  • Bank Transfer
  • Cash on Delivery
  • Purchase Order (Includes bugfix for setting PO number)

Fixed Issues (if relevant)

  1. [Test Coverage] Offline payments methods #601

Manual testing scenarios (*)

  1. cd dev/tests/api-functional
  2. ../../../vendor/bin/phpunit testsuite/Magento/GraphQl/Quote/Customer/SetOfflinePaymentMethodsOnCartTest.php
  3. ../../../vendor/bin/phpunit testsuite/Magento/GraphQl/Quote/Guest/SetOfflinePaymentMethodsOnCartTest.php

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@TomashKhamlai TomashKhamlai added the QA in progress We are checking label Apr 26, 2019
naydav added 2 commits April 29, 2019 14:36
…e-payment-test

# Conflicts:
#	app/code/Magento/QuoteGraphQl/Model/Resolver/SetPaymentMethodOnCart.php
#	app/code/Magento/QuoteGraphQl/etc/schema.graphqls
naydav added a commit that referenced this pull request Apr 29, 2019
@magento-engcom-team magento-engcom-team merged commit 5766e14 into magento:2.3-develop Apr 30, 2019
@ghost
Copy link

ghost commented Apr 30, 2019

Hi @pmclain, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@keharper
Copy link
Contributor

Documented as part of magento/devdocs#4502

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants