Skip to content
This repository has been archived by the owner on Nov 19, 2024. It is now read-only.

Removing JSCS doc link #5650

Closed
wants to merge 2 commits into from
Closed

Removing JSCS doc link #5650

wants to merge 2 commits into from

Conversation

brunoroeder
Copy link
Contributor

Purpose of this pull request

Removed the JSCS external link and mentions. The JSCS has merged with ESLint (Medium Post).

This PR fix #5632 5632

Affected DevDocs pages

Links to Magento source code

@devops-devdocs
Copy link
Collaborator

An admin must run tests on this PR before it can be merged.

@erikmarr
Copy link
Contributor

Looks like Magento still has the JSCS rules. @buskamuza and @lenaorobei can you confirm?

@erikmarr erikmarr added the Waiting for Response Waiting for response from internal/external parties label Oct 10, 2019
@lenaorobei
Copy link
Contributor

@erikmarr, yes, that's correct.

erikmarr
erikmarr reviewed Oct 10, 2019
View reviewed changes
guides/v2.2/coding-standards/code-standard-javascript.md

ESLint is a community-driven tool that detects errors and potential problems in JavaScript code.
It can use custom rules to enforce specific coding standards.

* [Magento ESLint Rules][eslint-rules]
* [Magento JSCS Rules][jscs-rules]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @lenaorobei for confirming. @brunoroeder since Magento still has the JSCS rules, let's not remove the link to the Magento JSCS Rules.

@dobooth
Copy link
Contributor

dobooth commented Oct 23, 2019

Hi @brunoroeder If you could please respond to the comment and fix the merge conflict, we can get this in. Thanks for the contribution.

@shrielenee
Copy link
Contributor

Hey @brunoroeder --- This PR has exceeded our 2 week timeframe. We are going to close this, but if you'd like to complete this so we may merge it please reopen it! 👍

@shrielenee shrielenee closed this Oct 31, 2019
@ghost
Copy link

ghost commented Oct 31, 2019

Hi @brunoroeder, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@hguthrie hguthrie removed the Waiting for Response Waiting for response from internal/external parties label Oct 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@erikmarr erikmarr erikmarr left review comments

@buskamuza buskamuza Awaiting requested review from buskamuza

@lenaorobei lenaorobei Awaiting requested review from lenaorobei

Assignees

@jcalcaben jcalcaben

@erikmarr erikmarr

Labels
Partner: Trezo partners-contribution PR created by Magento partner Progress: review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Incorrect link to JSCS site.
9 participants
@brunoroeder @devops-devdocs @erikmarr @lenaorobei @dobooth @shrielenee @jcalcaben @hguthrie @magento-engcom-team