Skip to content
This repository has been archived by the owner on Nov 19, 2024. It is now read-only.

GraphQL: Update Braintree attribute descriptions #5653

Merged
merged 2 commits into from
Oct 10, 2019
Merged

GraphQL: Update Braintree attribute descriptions #5653

merged 2 commits into from
Oct 10, 2019

Conversation

keharper
Copy link
Contributor

Purpose of this pull request

This pull request (PR) updates the description for attributes associated with the Braintree payment method. These descriptions were contributed in the 2.3.4 codebase, but they are still applicable to 2.3.3.

Affected DevDocs pages

  • guides/v2.3/graphql/mutations/create-braintree-client-token.md
  • guides/v2.3/graphql/mutations/set-payment-place-order.md

Links to Magento source code

@keharper keharper added Internal Dev Differentiates work between community and Magento staff Technical Updates to the code or processes that alter the technical content of the doc Community Docs impacted by community code contribution xx2.3.3 Magento 2.3.3 changes labels Oct 10, 2019
@keharper keharper self-assigned this Oct 10, 2019
@keharper keharper requested a review from erikmarr October 10, 2019 18:59
@keharper keharper changed the title GraphQL: Update attribute descriptions GraphQL: Update Braintree attribute descriptions Oct 10, 2019
erikmarr
erikmarr approved these changes Oct 10, 2019
View reviewed changes
Copy link
Contributor

@erikmarr erikmarr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@keharper
Copy link
Contributor Author

running tests

@keharper keharper merged commit 4e65bca into master Oct 10, 2019
@ghost
Copy link

ghost commented Oct 10, 2019

Hi @keharper, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@keharper keharper deleted the kh_small-community-changes branch October 10, 2019 19:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@erikmarr erikmarr erikmarr approved these changes

Assignees

@keharper keharper

@erikmarr erikmarr

Labels
Community Docs impacted by community code contribution Internal Dev Differentiates work between community and Magento staff Technical Updates to the code or processes that alter the technical content of the doc xx2.3.3 Magento 2.3.3 changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@keharper @erikmarr