Skip to content
This repository has been archived by the owner on Dec 19, 2019. It is now read-only.

Added description BraintreeInput #909

Merged

Conversation

sedonik
Copy link
Contributor

@sedonik sedonik commented Sep 5, 2019

Description (*)

Braintree payment method input has multiple fields like: device_data, is_active_payment_token_enabler, payment_method_nonce which don't have the description.

Issue

  1. [Braintree] Add description to BraintreeInput #876: [Braintree] Add description to BraintreeInput

Copy link
Contributor

@lenaorobei lenaorobei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The description should provide clear understanding of the field purpose.

payment_method_nonce: String!
is_active_payment_token_enabler: Boolean!
device_data: String
payment_method_nonce: String! @doc(description:"Required input for Braintrees payments")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately, the added description doesn't explain the field purpose.
The payment_method_nonce is a one-time payment token generated by Braintree payment gateway based on card details and this token is required to make sale transaction.

is_active_payment_token_enabler: Boolean!
device_data: String
payment_method_nonce: String! @doc(description:"Required input for Braintrees payments")
is_active_payment_token_enabler: Boolean! @doc(description:"Required input for Braintrees payments")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This field is required only if Vault is enabled for Braintree payment integration. The is_active_payment_token_enabler shows if an entered by a customer credit/debit card should be tokenized for later usage.

device_data: String
payment_method_nonce: String! @doc(description:"Required input for Braintrees payments")
is_active_payment_token_enabler: Boolean! @doc(description:"Required input for Braintrees payments")
device_data: String @doc(description:"Additional information for Braintrees payments")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The device_data will be presented only in a case if Kount (advanced fraud protection) is enabled for Braintree payment integration. The device data contains a fingerprint provided by Braintree JS SDK and should be sent with sale transaction details to the Braintree payment gateway.

@sedonik
Copy link
Contributor Author

sedonik commented Sep 13, 2019

@lenaorobei, @joni-jones
Descriptions are updated.
Could you check?

Copy link
Contributor

@lenaorobei lenaorobei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see my suggestions.

app/code/Magento/BraintreeGraphQl/etc/schema.graphqls Outdated Show resolved Hide resolved
app/code/Magento/BraintreeGraphQl/etc/schema.graphqls Outdated Show resolved Hide resolved
sedonik and others added 2 commits September 17, 2019 00:13
Updated is_active_payment_token_enabler

Co-Authored-By: Lena Orobei <oorobei@magento.com>
Updated device_data

Co-Authored-By: Lena Orobei <oorobei@magento.com>
@magento-engcom-team
Copy link
Contributor

Hi @lenaorobei, thank you for the review.
ENGCOM-5859 has been created to process this Pull Request
✳️ @lenaorobei, could you please add one of the following labels to the Pull Request?

Label Description
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests

@ghost
Copy link

ghost commented Sep 25, 2019

Hi @sedonik, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants