-
Notifications
You must be signed in to change notification settings - Fork 156
Added description BraintreeInput #909
Added description BraintreeInput #909
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The description should provide clear understanding of the field purpose.
payment_method_nonce: String! | ||
is_active_payment_token_enabler: Boolean! | ||
device_data: String | ||
payment_method_nonce: String! @doc(description:"Required input for Braintrees payments") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unfortunately, the added description doesn't explain the field purpose.
The payment_method_nonce
is a one-time payment token generated by Braintree payment gateway based on card details and this token is required to make sale transaction.
is_active_payment_token_enabler: Boolean! | ||
device_data: String | ||
payment_method_nonce: String! @doc(description:"Required input for Braintrees payments") | ||
is_active_payment_token_enabler: Boolean! @doc(description:"Required input for Braintrees payments") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This field is required only if Vault is enabled for Braintree payment integration. The is_active_payment_token_enabler
shows if an entered by a customer credit/debit card should be tokenized for later usage.
device_data: String | ||
payment_method_nonce: String! @doc(description:"Required input for Braintrees payments") | ||
is_active_payment_token_enabler: Boolean! @doc(description:"Required input for Braintrees payments") | ||
device_data: String @doc(description:"Additional information for Braintrees payments") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The device_data
will be presented only in a case if Kount (advanced fraud protection) is enabled for Braintree payment integration. The device data contains a fingerprint provided by Braintree JS SDK and should be sent with sale transaction details to the Braintree payment gateway.
@lenaorobei, @joni-jones |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please see my suggestions.
Updated is_active_payment_token_enabler Co-Authored-By: Lena Orobei <oorobei@magento.com>
Updated device_data Co-Authored-By: Lena Orobei <oorobei@magento.com>
Hi @lenaorobei, thank you for the review.
|
Hi @sedonik, thank you for your contribution! |
Description (*)
Braintree payment method input has multiple fields like: device_data, is_active_payment_token_enabler, payment_method_nonce which don't have the description.
Issue