Skip to content
This repository was archived by the owner on Nov 19, 2024. It is now read-only.

GraphQL: Add section about CORS #7629

Merged
merged 4 commits into from
Aug 11, 2020
Merged

GraphQL: Add section about CORS #7629

merged 4 commits into from
Aug 11, 2020

Conversation

keharper
Copy link
Contributor

@keharper keharper commented Jul 29, 2020 •
edited
Loading

Purpose of this pull request

This pull request (PR) adds a section about enabling Cross-Origin Resource Sharing (CORS) for GraphQL.

Affected DevDocs pages

Links to Magento source code

@keharper keharper self-assigned this Jul 29, 2020
@keharper keharper added 2.4.1 Community Docs impacted by community code contribution Internal Dev Differentiates work between community and Magento staff Major Update Significant original updates to existing content and removed Progress: review labels Jul 29, 2020
michalderlatka
michalderlatka previously requested changes Jul 30, 2020
View reviewed changes
Copy link

@michalderlatka michalderlatka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One thing needs to be changed: HTTP headers are used, not HTML

@keharper
Copy link
Contributor Author

@michalderlatka Fixed.

@keharper keharper requested a review from cpartica August 3, 2020 16:28
erikmarr
erikmarr approved these changes Aug 3, 2020
View reviewed changes
Copy link
Contributor

@erikmarr erikmarr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

cpartica
cpartica approved these changes Aug 10, 2020
View reviewed changes
Copy link

@cpartica cpartica left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for timestamp you could just defined this as a unix timestamp

@keharper keharper dismissed michalderlatka’s stale review August 11, 2020 15:02

Dismissing review due to internal approval and inactivity

@keharper
Copy link
Contributor Author

running tests

@keharper keharper merged commit 3e8960e into 2.4.1-develop Aug 11, 2020
@ghost
Copy link

ghost commented Aug 11, 2020

Hi @keharper, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@keharper keharper deleted the kh_cors branch August 11, 2020 16:49
@keharper keharper mentioned this pull request Sep 3, 2020
Merged
@keharper keharper removed the Major Update Significant original updates to existing content label Sep 3, 2020
@keharper keharper mentioned this pull request Jan 3, 2021
Closed
8 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@cpartica cpartica cpartica approved these changes

@erikmarr erikmarr erikmarr approved these changes

@michalderlatka michalderlatka michalderlatka left review comments

Assignees

@keharper keharper

@cpartica cpartica

@erikmarr erikmarr

Labels
2.4.1 Community Docs impacted by community code contribution Internal Dev Differentiates work between community and Magento staff
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@keharper @michalderlatka @cpartica @erikmarr