This repository was archived by the owner on Nov 19, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
GraphQL: Document CORS support #8465
Labels
2.4.3
Community
Docs impacted by community code contribution
Major Update
Significant original updates to existing content
Partner: EY
Progress: done
Comments
Hi @keharper. Thank you for your report. Please, add a comment to assign the issue:
|
@magento I am working on this |
@G-Arvind If you've started working on this issue, be aware that there is now a |
This PR also contains documentation that was backed out. |
@G-Arvind A Magento development team is finishing the original PR. Do you want to submit a devdocs PR to cover the work that you completed, or would you prefer that I do all the work to complete this issue. If you want to start the work and get the credit for it:
Please let me know your decision by Thursday, February 25. |
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
2.4.3
Community
Docs impacted by community code contribution
Major Update
Significant original updates to existing content
Partner: EY
Progress: done
Community engineering issue
Type of Doc:
Magento 2 GitHub Issue: magento/magento2#31195
Magento 2 GitHub PR: magento/magento2#31484
Magento 2 version:
Notifications of Changes:
Content
Do not start working on this issue until Magento has approved PR magento/magento2#31484
Add documentation that describes GraphQL CORS support.
CORS support was originally a feature targeted for 2.4.2, but Magento did not merge that code into mainline. You can use the text in #7629 as a starting point, if the code in magento/magento2#31484 is compatible. (#7815 reverted those doc updates.)
Additional information
CORS support is a 2.4.3 feature. Create your PR off of the
2.4.3-develop
branch.As of the moment I'm writing this issue, there is no2.4.3-develop
branch. If the2.4.3-develop
branch exists when you start working on this issue, create your PR against it. Otherwise, create the PR against the2.4.2-develop
branch with the knowledge that it will need to be rebased.If this iteration of CORS support does not warrant a new topic, then be sure to break the symlink using the
rake symlink:replace_at path=src/guides/v2.4/graphql/send-request.md
command.The text was updated successfully, but these errors were encountered: