Skip to content
This repository has been archived by the owner on Dec 19, 2019. It is now read-only.

[Test coverage] testReSetShippingMethod #485

Closed
naydav opened this issue Mar 15, 2019 · 1 comment
Closed

[Test coverage] testReSetShippingMethod #485

naydav opened this issue Mar 15, 2019 · 1 comment
Assignees
@vovsky
Labels
Contribution Day Tickets is good for start on Contribution Day good first issue Good for newcomers test-coverage
Milestone
Release: 2.3.2

Comments

@naydav
Copy link
Contributor

naydav commented Mar 15, 2019

Query scheme: app/code/Magento/QuoteGraphQl/etc/schema.graphqls

Need to add testReSetPaymentMethod case to

\Magento\GraphQl\Quote\Customer\SetShippingMethodsOnCartTest
\Magento\GraphQl\Quote\Guest\SetShippingMethodsOnCartTest

Functionality should be fixed if needed.

Please, reuse current fixtures instead of creating new.
Example: https://github.com/magento/graphql-ce/pull/471/files

More examples you could find in
https://github.com/magento/graphql-ce/tree/2.3-develop/dev/tests/api-functional/testsuite/Magento/GraphQl/Quote/Customer

https://github.com/magento/graphql-ce/tree/2.3-develop/dev/tests/api-functional/testsuite/Magento/GraphQl/Quote/Guest
@naydav naydav added good first issue Good for newcomers Contribution Day Tickets is good for start on Contribution Day labels Mar 15, 2019
@naydav naydav added this to the Release: 2.3.2 milestone Mar 15, 2019
@vovsky vovsky self-assigned this Mar 16, 2019
vovsky added a commit that referenced this issue Mar 16, 2019
@vovsky
issue #485 [Test coverage] testReSetShippingMethod
5d9a64e
magento-engcom-team added a commit that referenced this issue Mar 30, 2019
@magento-engcom-team
ENGCOM-4608: issue #485 [Test coverage] testReSetShippingMethod #496
7c5769d 
 - Merge Pull Request #496 from magento/graphql-ce:485-testReSetShippingMethod
 - Merged commits:
   1. 4f19d03
   2. 43f5bce
   3. 4bdc30e
   4. f9ecace
   5. 5d9a64e
   6. f01dc00
   7. 16ce046
   8. c2f15b3
   9. 14d5c3d
   10. 2643424
   11. cf4eb72
   12. 829a39b
   13. 4837778
   14. 1c582f1
magento-engcom-team pushed a commit that referenced this issue Mar 30, 2019
@naydav
ENGCOM-4608: issue #485 [Test coverage] testReSetShippingMethod #496
022d6e6
@vovsky vovsky mentioned this issue Mar 30, 2019
Merged
4 tasks
@naydav
Copy link
Contributor Author

naydav commented Mar 30, 2019

#496

@naydav naydav closed this as completed Mar 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@vovsky vovsky

Labels
Contribution Day Tickets is good for start on Contribution Day good first issue Good for newcomers test-coverage
Projects
None yet
Milestone
Release: 2.3.2
Development

No branches or pull requests
2 participants
@naydav @vovsky