issue #485 [Test coverage] testReSetShippingMethod #496
Conversation
…aphql-PR-yogesh-5
| self::assertArrayHasKey('setShippingMethodsOnCart', $response); | ||
| self::assertArrayHasKey('cart', $response['setShippingMethodsOnCart']); | ||
| self::assertArrayHasKey('shipping_addresses', $response['setShippingMethodsOnCart']['cart']); | ||
| foreach ($response['setShippingMethodsOnCart']['cart']['shipping_addresses'] as $address) { |
There was a problem hiding this comment.
If we use foreach that means we have a few shipping addresses for Cart.
Need to check why don't we have an exception Multishipping is not supported with this preconditions
Thanks
There was a problem hiding this comment.
Do you mean to change shipping_addresses field of Cart type to shipping_address
and to throw Multishipping is not supported exception in \Magento\QuoteGraphQl\Model\Resolver\ShippingAddresses resolver if there is more than one shipping address?
There was a problem hiding this comment.
Do you mean to change shipping_addresses field of Cart type to shipping_address
and to throw Multishipping is not supported exception in \Magento\QuoteGraphQl\Model\Resolver\ShippingAddresses resolver if there is more than one shipping address?
…ogesh-5' into 2.3-develop-graphql-PR-yogesh-5
…aphql-PR-yogesh-5
…aphql-PR-yogesh-5
…hippingMethod # Conflicts: # dev/tests/api-functional/testsuite/Magento/GraphQl/Quote/Customer/SetShippingMethodsOnCartTest.php # dev/tests/api-functional/testsuite/Magento/GraphQl/Quote/Guest/SetShippingMethodsOnCartTest.php
…ogesh-5' into 485-testReSetShippingMethod
|
Hi @vovsky, thank you for your contribution! |
Description (*)
Added API functional test to cover reset shipping method case.
Fixed Issues (if relevant)
Contribution checklist (*)