Skip to content
This repository has been archived by the owner on Dec 19, 2019. It is now read-only.

[Checkout] Replace usage of CartItemQuantity with CartItemInterface #890

Closed
paliarush opened this issue Sep 3, 2019 · 2 comments
Closed

[Checkout] Replace usage of CartItemQuantity with CartItemInterface #890

paliarush opened this issue Sep 3, 2019 · 2 comments
Assignees
@VitaliyBoyko
Labels
Architects: approved Issue is checked and approved by architecture team. Checkout Contribution Day Tickets is good for start on Contribution Day documentation-completed Fixed in 2.3.x
Milestone
Release: 2.3.4

Comments

@paliarush
Copy link
Contributor

paliarush commented Sep 3, 2019 •
edited by lenaorobei
Loading

Acceptance criteria:

  1. ShippingCartAddress has field cart_items, which should return CartItemInterface instead of CartItemQuantity
  2. All fields in CartItemQuantity should be deprecated (so this type can be completely removed in the future releases)
  3. Since CartItemInterface is wider than CartItemQuantity, custom resolver may need to be implemented for the missing fields
  4. Deprecate items_weight in ShippingCartAddress
  5. Changes must be covered with API functional tests
@paliarush paliarush added Contribution Day Tickets is good for start on Contribution Day Checkout labels Sep 3, 2019
@VitaliyBoyko VitaliyBoyko self-assigned this Sep 4, 2019
@VitaliyBoyko VitaliyBoyko mentioned this issue Sep 4, 2019
Merged
@lenaorobei lenaorobei added this to the Release: 2.3.4 milestone Sep 17, 2019
@lenaorobei lenaorobei added the Architects: approved Issue is checked and approved by architecture team. label Sep 17, 2019
lenaorobei added a commit that referenced this issue Oct 23, 2019
@lenaorobei
#890: [Checkout] Replace usage of CartItemQuantity with CartItemInter…
795931f 
…face
lenaorobei added a commit that referenced this issue Oct 23, 2019
@lenaorobei
#890: [Checkout] Replace usage of CartItemQuantity with CartItemInter…
8b51315 
…face
@lenaorobei
Copy link
Contributor

As per discussion with @paliarush and @buskamuza it was decided to introduce cart_items_v2 to keep backward compatibility.

lenaorobei added a commit that referenced this issue Oct 23, 2019
@lenaorobei
#890: [Checkout] Replace usage of CartItemQuantity with CartItemInter…
344648f 
…face
lenaorobei added a commit that referenced this issue Oct 23, 2019
@lenaorobei
#890: [Checkout] Replace usage of CartItemQuantity with CartItemInter…
b9f708b 
…face
@magento-engcom-team
Copy link
Contributor

Hi @paliarush. Thank you for your report.
The issue has been fixed in #899 by @VitaliyBoyko in 2.3-develop branch
Related commit(s):

The fix will be available with the upcoming 2.3.4 release.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@VitaliyBoyko VitaliyBoyko

Labels
Architects: approved Issue is checked and approved by architecture team. Checkout Contribution Day Tickets is good for start on Contribution Day documentation-completed Fixed in 2.3.x
Projects
None yet
Milestone
Release: 2.3.4
Development

No branches or pull requests
5 participants
@paliarush @keharper @lenaorobei @VitaliyBoyko @magento-engcom-team