This repository has been archived by the owner on Dec 19, 2019. It is now read-only.
graphQl-890: Replaced usage of the CartItemQuantity with the CartItem… #899
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lenaorobei
approved these changes
Sep 4, 2019
|
Hi @lenaorobei, thank you for the review.
|
lenaorobei
suggested changes
Sep 10, 2019
…temQuantity-with-CartItemInterface' of github.com:magento/graphql-ce into GraphQl-890-Replaced-usage-of-CartItemQuantity-with-CartItemInterface # Conflicts: # app/code/Magento/QuoteGraphQl/etc/schema.graphqls
|
@lenaorobei Done |
lenaorobei
suggested changes
Sep 20, 2019
| customer_notes: String | ||
| items_weight: Float @deprecated |
There was a problem hiding this comment.
Please add reason here.
| } | ||
|
|
||
| type BillingCartAddress implements CartAddressInterface { | ||
| customer_notes: String @deprecated (reason: "The field is used only in shipping address") | ||
| } | ||
|
|
||
| type CartItemQuantity { | ||
| type CartItemQuantity @deprecated(reason: "Use CartItemInterface instead") { |
There was a problem hiding this comment.
From the ticket:
All fields in CartItemQuantity should be deprecated (so this type can be completely removed in the future releases)
added 2 commits
September 27, 2019 10:24
…temQuantity-with-CartItemInterface' of github.com:magento/graphql-ce into GraphQl-890-Replaced-usage-of-CartItemQuantity-with-CartItemInterface
VitaliyBoyko
added
Contribution Day
m2-community-project
bot
added
Progress: changes requested
and removed
Progress: approved
Progress: needs update
labels
lenaorobei
suggested changes
Oct 14, 2019
…hQl-890-Replaced-usage-of-CartItemQuantity-with-CartItemInterface
lenaorobei
approved these changes
Oct 28, 2019
|
Hi @VitaliyBoyko, thank you for your contribution! |
okorshenko
deleted the
GraphQl-890-Replaced-usage-of-CartItemQuantity-with-CartItemInterface
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…Interface
Description (*)
Replaced usage of the CartItemQuantity with the CartItemInterface in the GraphQl scheme.
Fixed Issues (if relevant)