Skip to content
This repository has been archived by the owner on Dec 19, 2019. It is now read-only.

[Test Coverage] Extend test coverage for BraintreeGraphQl #981

Closed
TomashKhamlai opened this issue Oct 2, 2019 · 0 comments
Closed

[Test Coverage] Extend test coverage for BraintreeGraphQl #981

TomashKhamlai opened this issue Oct 2, 2019 · 0 comments
Labels
Component: BraintreeGraphQl
Milestone
Release: 2.3.4

Comments

@TomashKhamlai
Copy link
Contributor

TomashKhamlai commented Oct 2, 2019 •
edited
Loading

Description:

Cover with API-functional tests:

graphql-ce/app/code/Magento/BraintreeGraphQl/Model/Resolver/CreateBraintreeClientToken.php

Line 65 in 169ac1b

$params[PaymentDataBuilder::MERCHANT_ACCOUNT_ID] = $merchantAccountId;

graphql-ce/app/code/Magento/BraintreeGraphQl/Model/BraintreeDataProvider.php

Line 43 in 1132a47

__('Required parameter "is_active_payment_token_enabler" for "braintree" is missing.')

TestCases:

Examples:

Magento\GraphQl\Customer
Magento\GraphQl\Quote\Customer

Guide:

Graphql Functional Testing
@TomashKhamlai TomashKhamlai self-assigned this Oct 2, 2019
@TomashKhamlai TomashKhamlai mentioned this issue Oct 3, 2019
Merged
4 tasks
@lenaorobei lenaorobei added this to the Release: 2.3.4 milestone Oct 10, 2019
magento-engcom-team added a commit that referenced this issue Oct 13, 2019
@magento-engcom-team
ENGCOM-6028: #981 Extend test coverage for BraintreeGraphQl #983
b3ea385 
 - Merge Pull Request #983 from TomashKhamlai/graphql-ce:issue/981
 - Merged commits:
   1. 287e906
magento-engcom-team pushed a commit that referenced this issue Oct 13, 2019
@lenaorobei
ENGCOM-6028: #981 Extend test coverage for BraintreeGraphQl #983
86681a5
magento-engcom-team added a commit that referenced this issue Oct 13, 2019
@magento-engcom-team
🔃 [Magento Community Engineering] Community Contributions - GraphQL
14d6388 
Accepted Community Pull Requests:
 - #873: graphQl-509: `save_in_address_book` has no impact on Address Book (by @kisroman)
 - #991: graphQl-987: [Test coverage] Cover exceptions in Magento\QuoteGraphQl� (by @kisroman)
 - #995: #985: Remove unnecessary exceptions (by @atwixfirster)
 - #997: #975: [Test coverage] Cover CartAddressTypeResolver (by @atwixfirster)
 - #990: Extend test coverage for CustomerDownloadableGraphQl (by @TomashKhamlai)
 - #983: #981 Extend test coverage for BraintreeGraphQl (by @TomashKhamlai)
 - #973: GraphQl-972: added support of the Global scope in the config fixture (by @VitaliyBoyko)


Fixed GitHub Issues:
 - magento/magento2#975: [Question] Have traits been considered for the Interceptor classes? (reported by @fooman) has been fixed in #997 by @atwixfirster in 2.3-develop branch
   Related commits:
     1. 493d744

 - magento/magento2#989: make build artifacts accessable (reported by @Flyingmana) has been fixed in #990 by @TomashKhamlai in 2.3-develop branch
   Related commits:
     1. bccd287

 - magento/magento2#972: Pub/Static directory is empty (reported by @mrugeshrocks) has been fixed in #973 by @VitaliyBoyko in 2.3-develop branch
   Related commits:
     1. 3489da5
     2. 63bd232
     3. b64a485
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Component: BraintreeGraphQl
Projects
None yet
Milestone
Release: 2.3.4
Development

No branches or pull requests
2 participants
@TomashKhamlai @lenaorobei