Skip to content
This repository has been archived by the owner on Dec 19, 2019. It is now read-only.

#981 Extend test coverage for BraintreeGraphQl #983

Merged
merged 1 commit into from
Oct 13, 2019
Merged

#981 Extend test coverage for BraintreeGraphQl #983

merged 1 commit into from
Oct 13, 2019

Conversation

TomashKhamlai
Copy link
Contributor

@TomashKhamlai TomashKhamlai commented Oct 3, 2019 •
edited
Loading

Description (*)

Cover exception:

  • Required parameter "is_active_payment_token_enabler" for "braintree" is missing.

Cover:

  • Case when Magento\Braintree\Gateway\Request\PaymentDataBuilder receives MERCHANT_ACCOUNT_ID (deprecated)

Fixed Issues (if relevant)

  1. [Test Coverage] Extend test coverage for BraintreeGraphQl #981: [Test Coverage] Extend test coverage for BraintreeGraphQl

Manual testing scenarios (*)

  1. n/a

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@TomashKhamlai TomashKhamlai changed the title #981 Extend test coverage #981 Extend test coverage for BraintreeGraphQl Oct 3, 2019
@TomashKhamlai
Extend test coverage for BraintreeGraphQ
287e906 
Cover exception:
 - `Required parameter "is_active_payment_token_enabler" for "braintree" is missing.`

Cover:
 - Case when Magento\Braintree\Gateway\Request\PaymentDataBuilder receives MERCHANT_ACCOUNT_ID (deprecated)

Signed-off-by: Tomash Khamlai <tomash.khamlai@gmail.com>
@magento-engcom-team
Copy link
Contributor

Hi @lenaorobei, thank you for the review.
ENGCOM-6028 has been created to process this Pull Request
✳️ @lenaorobei, could you please add one of the following labels to the Pull Request?

Label Description
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests

magento-engcom-team pushed a commit that referenced this pull request Oct 13, 2019
@lenaorobei
ENGCOM-6028: #981 Extend test coverage for BraintreeGraphQl #983
86681a5
@magento-engcom-team magento-engcom-team merged commit 287e906 into magento:2.3-develop Oct 13, 2019
@ghost
Copy link

ghost commented Oct 13, 2019

Hi @TomashKhamlai, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lenaorobei lenaorobei lenaorobei approved these changes

@paliarush paliarush Awaiting requested review from paliarush

Assignees

@lenaorobei lenaorobei

Labels
Auto-Tests: Covered Award: test coverage Release Line: 2.3
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TomashKhamlai @magento-engcom-team @lenaorobei