Skip to content
This repository has been archived by the owner on Dec 19, 2019. It is now read-only.

[ThemeGraphql] Getting values from StoreConfig is not possible #318

Merged
merged 1 commit into from
Jan 31, 2019
Merged

[ThemeGraphql] Getting values from StoreConfig is not possible #318

merged 1 commit into from
Jan 31, 2019

Conversation

vasilii-b
Copy link

Description (*)

This PR aims to allow developers to get store design configuration (from Html Head, Footer and Header) information using Graphql.

Fixed Issues (if relevant)

  1. [ThemeGraphql] Getting values from StoreConfig is not possible #317: [ThemeGraphql] Getting values from StoreConfig is not possible

Manual testing scenarios (*)

Provided in original issue description

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-cicd2
Copy link
Contributor

magento-cicd2 commented Jan 22, 2019 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@vasilii-b vasilii-b requested a review from naydav January 22, 2019 09:29
@vasilii-b vasilii-b mentioned this pull request Jan 23, 2019
Closed
6 tasks
@magento-engcom-team magento-engcom-team added this to the Release: 2.3.1 milestone Jan 28, 2019
@magento-engcom-team magento-engcom-team merged commit f7b40b2 into magento:2.3-develop Jan 31, 2019
@ghost
Copy link

ghost commented Jan 31, 2019

Hi @vasilii-b, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

magento-engcom-team pushed a commit that referenced this pull request Jan 31, 2019
@naydav
ENGCOM-4007: [ThemeGraphql] Getting values from StoreConfig is not po…
8bbb073 
…ssible #318
@vasilii-b vasilii-b deleted the issue-317-ThemeGraphql-StoreConfig-return-values branch January 31, 2019 14:28
@naydav naydav mentioned this pull request Jan 31, 2019
Closed
@awilcoxa awilcoxa mentioned this pull request Mar 4, 2019
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@naydav naydav naydav approved these changes

Assignees

@naydav naydav

@vasilii-b vasilii-b

Labels
Award: bug fix Partner: Atwix partners-contribution Release Line: 2.3
Projects
None yet
Milestone
Release: 2.3.1
Development

Successfully merging this pull request may close these issues.
4 participants
@vasilii-b @magento-cicd2 @naydav @magento-engcom-team