Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Handle title and meta tags for navigation on client side #774

Closed
wants to merge 2 commits into from
Closed

[Bug] Handle title and meta tags for navigation on client side #774

wants to merge 2 commits into from

Conversation

vasilii-b
Copy link

This PR is a:

  • New feature
  • Enhancement/Optimization
  • Refactor
  • Bugfix
  • Test for existing code
  • Documentation

Summary

When this pull request is merged, it will:

  1. Solve issue [Bug] Handle title and meta tags for navigation on client side #422
  2. Adds page default title from System Configuration
  3. Appends prefix and suffix (from System Configuration) to the page title if necessary
  4. Adds category title, meta title, meta keywords and meta description to the current App state
  5. Adds product title, meta title, meta keywords and meta description to the current App state
  6. Introduces the react-helmet package to venia-concept

Additional information

⚠️ This PR is dependent on one opened PR magento/graphql-ce#318.
The thing is that that PR solves GraphQl issue for getting information about store design configuration, like default title, title prefix, title suffix, and so on, which are used to solve mentioned issue above.


Would be nice to have someone "instruct" me on what's wrong in this PR, how we can improve the current approach and give some advices for future PR.

P.S. this is my 1st PR and commitment to PWA

@magento-cicd2
Copy link

magento-cicd2 commented Jan 23, 2019

CLA assistant check
All committers have signed the CLA.

@vercel
Copy link

vercel bot commented Jan 23, 2019

This pull request is automatically deployed with Now.
To access deployments, click Details below or on the icon next to each push.

…-422-handle-title-meta-for-navigation-on-client-side

* magento-pwa/release/2.0:
  Apply classnames in Section component (#773)
@coveralls
Copy link

coveralls commented Jan 23, 2019

Coverage Status

Coverage decreased (-0.5%) to 57.288% when pulling f406ad2 on vasilii-b:bug/issue-422-handle-title-meta-for-navigation-on-client-side into 2278875 on magento-research:release/2.0.

@zetlen
Copy link
Contributor

zetlen commented Jan 29, 2019

Thank you for chipping in! I see the benefits of rendering with React as much as possible, but I'm not sure this is the time to try it. This change would remove the server-rendered metadata that gives us SEO and SMO.

@zetlen zetlen closed this Jan 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants