[Bug] Handle title and meta tags for navigation on client side #774
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a:
Summary
When this pull request is merged, it will:
react-helmet
package tovenia-concept
Additional information
The thing is that that PR solves GraphQl issue for getting information about store design configuration, like
default title
,title prefix
,title suffix
, and so on, which are used to solve mentioned issue above.Would be nice to have someone "instruct" me on what's wrong in this PR, how we can improve the current approach and give some advices for future PR.
P.S. this is my 1st PR and commitment to PWA