GraphQl-662: Test coverage of USPS shipping method

[atwixfirster]

#662

Description (*)

Works with sandbox USPS account.

@naydav , unfortunately I did not find a way how to emulate USPS service without values in the "User ID" and "Password" fields.

On my local instance to verify Magento\GraphQl\Usps\SetUspsShippingMethodsOnCartTest::testSetUpsShippingMethod() test I used my USPS sandbox account.

Thank you!

[atwixfirster]

@naydav , I've a proposition for you here.

On my local environment I've used my USPS sandbox account.

May be a good idea to have the appropriate one for Magento test instance. To provide USPS credentials and hide them from the 3rd eyes my proposition is use
dev/tests/api-functional/config/config-global.php config file with the next content (for USPS):

<?php
/**
 * Copyright © Magento, Inc. All rights reserved.
 * See COPYING.txt for license details.
 */

return [
    'carriers' => [
        'usps' => [
            'userid' => '0:3:xxxxxxxx==',
            'password' => '0:3:yyyyyyyyy==',
        ]
    ]
];

where 0:3:xxxxxxxx== is an encoded User ID and 0:3:yyyyyyyyy== is an encoded account Password.

Please let me know your thoughts.

Thank you!

[atwixfirster]

@naydav , ticket is ready for your review.

Thank you!

[naydav]

@atwixfirster
As we talk early, need to introduce some mock object instead of 'real caller' object
Our tests should not depend on external system

The best way is creating preference in GraphQLTestModule and replace real object on our internal mock object

[magento-engcom-team]

Hi @lenaorobei, thank you for the review.
ENGCOM-5284 has been created to process this Pull Request
✳️ @lenaorobei, could you please add one of the following labels to the Pull Request?

Label	Description
Auto-Tests: Covered	All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered	Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required	Changes in Pull Request does not require coverage by auto-tests

[magento-engcom-team]

Hi @naydav, thank you for the review.
ENGCOM-5284 has been created to process this Pull Request
✳️ @naydav, could you please add one of the following labels to the Pull Request?

Label	Description
Auto-Tests: Covered	All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered	Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required	Changes in Pull Request does not require coverage by auto-tests

[magento-engcom-team]

Hi @naydav, thank you for the review.
ENGCOM-5284 has been created to process this Pull Request

[ghost]

Hi @atwixfirster, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.