Skip to content
This repository has been archived by the owner on Dec 19, 2019. It is now read-only.

#486 added customer account validation in Quote operations #714

Merged
merged 7 commits into from
Jun 21, 2019
Merged

#486 added customer account validation in Quote operations #714

merged 7 commits into from
Jun 21, 2019

Conversation

vovsky
Copy link
Contributor

@vovsky vovsky commented May 16, 2019

Description

Added customer account validation in Quote operations.
API functional tests have been added to \Magento\GraphQl\Quote\Customer\GetCartTest

Fixed Issues (if relevant)

  1. Add customer account validation in Quote operations #486: Add customer account validation in Quote operations

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@vovsky vovsky requested review from naydav and rogyar May 16, 2019 13:49
@TomashKhamlai TomashKhamlai self-assigned this May 30, 2019
@TomashKhamlai TomashKhamlai added the QA in progress We are checking label May 30, 2019
@lenaorobei
Copy link
Contributor

@magento run all tests

@TomashKhamlai
Copy link
Contributor

Hi, @vovsky

Yesterday, before event I noticed the problem that Customer can't get token after he was unlocked.

There are always chances that something went wrong on my side but please check this twice and share results in comments. I will retry testing and share more details on reproducing this case.

Cc: @lenaorobei

@TomashKhamlai TomashKhamlai added QA failed and removed QA in progress We are checking labels Jun 11, 2019
@vovsky
Copy link
Contributor Author

vovsky commented Jun 12, 2019

@TomashKhamlai I have tried to unlock locked customer and perform quote operations. Please check method testGetCartForUnlockedCustomer in this temporary PR https://github.com/magento/graphql-ce/pull/737/files . Is this what you mean? Thank you

@TomashKhamlai
Copy link
Contributor

Hi, @vovsky, I am not able to do this for some period of time. Excuse me. Please contact with reviewers.

@naydav naydav changed the base branch from 2.3-develop to magento/graphql-ce#741 June 14, 2019 16:51
@naydav naydav changed the base branch from magento/graphql-ce#741 to 2.3-develop June 14, 2019 17:39
@naydav naydav mentioned this pull request Jun 14, 2019
Closed
@magento-engcom-team
Copy link
Contributor

Hi @naydav, thank you for the review.
ENGCOM-5295 has been created to process this Pull Request

@naydav naydav force-pushed the 486-add-customer-account-validation-in-quote-operations branch from ff2768c to 0a68474 Compare June 20, 2019 19:06
@magento-engcom-team magento-engcom-team merged commit 0890aa8 into magento:2.3-develop Jun 21, 2019
@ghost
Copy link

ghost commented Jun 21, 2019

Hi @vovsky, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@naydav naydav mentioned this pull request Jun 21, 2019
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@naydav naydav naydav approved these changes

@rogyar rogyar Awaiting requested review from rogyar

Assignees

@naydav naydav

@TomashKhamlai TomashKhamlai

Labels
Auto-Tests: Covered Award: test coverage Component: CustomerGraphQl Component: DownloadableGraphQl Component: QuoteGraphQl Component: SalesGraphQl Component: VaultGraphQl Partner: Atwix partners-contribution Progress: accept Release Line: 2.3
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@vovsky @lenaorobei @TomashKhamlai @magento-engcom-team @naydav