#518 Put all variable assignments in the same places

magento · Feb 17, 2018 · 131fc1c · 131fc1c
1 parent 68694a8
commit 131fc1c
Showing 1 changed file with 2 additions and 3 deletions.
diff --git a/app/code/Magento/InventoryShipping/Model/DefaultShippingAlgorithm.php b/app/code/Magento/InventoryShipping/Model/DefaultShippingAlgorithm.php
@@ -130,23 +130,22 @@ public function execute(OrderInterface $order): ShippingAlgorithmResultInterface
 
         /** @var OrderItemInterface|OrderItem $orderItem */
         foreach ($order->getItems() as $orderItem) {
+            $itemSku = $orderItem->getSku();
             $qtyToDeliver = $orderItem->getQtyOrdered();
 
             if ($orderItem->isDeleted() || $orderItem->getParentItemId() || $this->isZero($qtyToDeliver)) {
                 continue;
             }
 
-            $itemSku = $orderItem->getSku();
             foreach ($sources as $source) {
                 $sourceItem = $this->getStockItemBySku($source->getSourceCode(), $itemSku);
                 $sourceItemQty = $sourceItem->getQuantity();
+                $qtyToDeduct = min($sourceItemQty, $qtyToDeliver);
 
                 if ($this->isZero($sourceItemQty)) {
                     continue;
                 }
 
-                $qtyToDeduct = min($sourceItemQty, $qtyToDeliver);
-
                 $sourceSelections[] = $this->sourceSelectionFactory->create([
                     'sourceCode' => $sourceItem->getSourceCode(),
                     'sourceItemSelections' => $this->sourceItemSelectionFactory->create([