Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplest “By Priority” Algorithm implementation #518

Closed
naydav opened this issue Feb 7, 2018 · 1 comment
Closed

Simplest “By Priority” Algorithm implementation #518

naydav opened this issue Feb 7, 2018 · 1 comment
Assignees
@roma-glushko
Labels
WIP
Milestone
MSI (MVP Release)...

Comments

@naydav
Copy link

naydav commented Feb 7, 2018

  1. Need to adapt \Magento\InventoryShipping\Model\DefaultShippingAlgorithm to load source items by priority
  2. Need to check why do we need $qtyToDeliver < 0.0001 condition
  3. Adapt app/code/Magento/InventoryShipping/view/adminhtml/templates/order/view/tab/source_selection.phtml template according to different statuses of \Magento\InventoryShipping\Model\ShippingAlgorithmResult\ShippingAlgorithmResult::isShippable
@naydav naydav added this to the MSI Part I milestone Feb 7, 2018
@roma-glushko roma-glushko self-assigned this Feb 7, 2018
roma-glushko pushed a commit that referenced this issue Feb 15, 2018
#518 [WIP] Loaded sources by priority
f3bbc5f
roma-glushko pushed a commit that referenced this issue Feb 17, 2018
#518 Refactored the default shipping selection algo to process source…
68694a8 
…s in priority order
roma-glushko pushed a commit that referenced this issue Feb 17, 2018
#518 Put all variable assignments in the same places
131fc1c
roma-glushko pushed a commit that referenced this issue Feb 17, 2018
#518 Refactored shipping selection algo classname
32ffc90
roma-glushko pushed a commit that referenced this issue Feb 17, 2018
#518 Changed the epsilon
74a08e4
roma-glushko pushed a commit that referenced this issue Feb 17, 2018
#518 Added the message if order items can’t be delivered by the curre…
adfa7f7 
…nt algo
roma-glushko pushed a commit that referenced this issue Feb 17, 2018
[TASK] #518 Commented the algorithm
1f3cf0b
roma-glushko pushed a commit that referenced this issue Feb 17, 2018
#518 Renamed the classname
9adcaec
roma-glushko pushed a commit that referenced this issue Feb 17, 2018
#518 Made the tab hidden if source items are not enough to deliver th…
39ca211 
…e order
@roma-glushko roma-glushko mentioned this issue Feb 22, 2018
Merged
4 tasks
naydav pushed a commit that referenced this issue Mar 1, 2018
Merge pull request #560 from magento-engcom/518-priority-adjustments-…
f4ab977 
…simple-selection-algorithm

#518 Simplest “By Priority” Algorithm implementation
@naydav
Copy link
Author

naydav commented Mar 1, 2018

#560

@naydav naydav closed this as completed Mar 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@roma-glushko roma-glushko

Labels
WIP
Projects
None yet
Milestone
MSI (MVP Release) 1.0-Beta
Development

No branches or pull requests
2 participants
@naydav @roma-glushko