#518 Made the tab hidden if source items are not enough to deliver th…

…e order
magento · Feb 17, 2018 · 39ca211 · 39ca211
1 parent 9adcaec
commit 39ca211
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 4 deletions.
diff --git a/app/code/Magento/InventoryShipping/Block/Adminhtml/Order/View/Tab/SourceSelection.php b/app/code/Magento/InventoryShipping/Block/Adminhtml/Order/View/Tab/SourceSelection.php
@@ -116,7 +116,7 @@ public function getTabTitle()
      */
     public function canShowTab()
     {
-        return true;
+        return $this->isShippable();
     }
 
     /**

diff --git a/.../Magento/InventoryShipping/view/adminhtml/templates/order/view/tab/source_selection.phtml b/.../Magento/InventoryShipping/view/adminhtml/templates/order/view/tab/source_selection.phtml
@@ -8,9 +8,6 @@
 
 /** @var Magento\InventoryShipping\Block\Adminhtml\Order\View\Tab\SourceSelection $block */
 ?>
-<?php if (!$block->isShippable()) : ?>
-    <div><?php echo __('Order items could not be shipped by the current shipping algorithm.'); ?></div>
-<?php endif; ?>
 <?php foreach ($block->getSourceSelections() as $sourceSelection) : ?>
     <table class="data-table admin__table-primary edit-order-table">
         <div class="admin__page-section-item-title">
-Original file line number
+Diff line change
@@ Expand Up / @@ -116,7 +116,7 @@ public function getTabTitle() @@
          */
         public function canShowTab()
         {
-            return true;
+            return $this->isShippable();
         }
         /**
@@ Expand Down @@