#518 Simplest “By Priority” Algorithm implementation #560
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
February 15, 2018 02:12
…s in priority order
maghamed
reviewed
Feb 17, 2018
| */ | ||
| private function isZero(float $floatNumber): bool | ||
| { | ||
| return $floatNumber < 0.0001; |
There was a problem hiding this comment.
it's a pity that Constant has been added just in PHP 7.2
PHP_FLOAT_EPSILON (float)
Smallest representable positive number x, so that x + 1.0 != 1.0. Available as of PHP 7.2.0.
Please, make the precision a bit less, like 0.0000001
added 5 commits
February 17, 2018 16:02
…selection-algorithm' into 518-priority-adjustments-simple-selection-algorithm
…518-priority-adjustments-simple-selection-algorithm
…selection-algorithm' into 518-priority-adjustments-simple-selection-algorithm
naydav
suggested changes
Feb 26, 2018
| * | ||
| * @return SourceItemInterface | ||
| */ | ||
| private function getStockItemBySku(string $stockCode, string $sku): SourceItemInterface |
There was a problem hiding this comment.
Description talks about one behavior
Method name talks about another behavior
Implementation return the other
Also, you can reuse \Magento\Inventory\Model\SourceItem\Command\GetSourceItemsBySkuInterface
naydav
reviewed
Feb 27, 2018
| * {@inheritdoc} | ||
| * This shipping algorithm just iterates over all the sources one by one in priority order | ||
| * | ||
| * @SuppressWarnings(PHPMD.CouplingBetweenObjects) |
There was a problem hiding this comment.
We should not add suppressing in new code (only in special cases)
We can split this class on a few, first is loading data, second is perform algorithm
added 4 commits
March 1, 2018 12:54
…tments-simple-selection-algorithm
magento-engcom-team
added
Award: complex
Award: test coverage
and removed
Award: complex
labels
maghamed
deleted the
518-priority-adjustments-simple-selection-algorithm
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement shipping selection algorithm by source priority.
Fixed Issues
To Do