#518 Simplest “By Priority” Algorithm implementation

app/code/Magento/Inventory/Model/StockSourceLink/Command/GetAssignedSourcesForStock.php

@@ -8,8 +8,8 @@
 namespace Magento\Inventory\Model\StockSourceLink\Command;
 
 use Magento\Framework\Api\SearchCriteriaBuilder;
+use Magento\Framework\Api\SortOrderBuilder;
 use Magento\Framework\Exception\LocalizedException;
-use Magento\InventoryApi\Api\Data\SourceInterface;
 use Magento\InventoryApi\Api\Data\StockSourceLinkInterface;
 use Magento\InventoryApi\Api\GetAssignedSourcesForStockInterface;
 use Magento\InventoryApi\Api\GetStockSourceLinksInterface;
@@ -41,22 +41,30 @@ class GetAssignedSourcesForStock implements GetAssignedSourcesForStockInterface
      */
     private $logger;
 
+    /**
+     * @var SortOrderBuilder
+     */
+    private $sortOrderBuilder;
+
     /**
      * @param SearchCriteriaBuilder $searchCriteriaBuilder
      * @param SourceRepositoryInterface $sourceRepository
      * @param GetStockSourceLinksInterface $getStockSourceLinks
+     * @param SortOrderBuilder $sortOrderBuilder
      * @param LoggerInterface $logger
      */
     public function __construct(
         SearchCriteriaBuilder $searchCriteriaBuilder,
         SourceRepositoryInterface $sourceRepository,
         GetStockSourceLinksInterface $getStockSourceLinks,
+        SortOrderBuilder $sortOrderBuilder,
         LoggerInterface $logger
     ) {
         $this->searchCriteriaBuilder = $searchCriteriaBuilder;
         $this->sourceRepository = $sourceRepository;
         $this->getStockSourceLinks = $getStockSourceLinks;
         $this->logger = $logger;
+        $this->sortOrderBuilder = $sortOrderBuilder;
     }
 
     /**
@@ -65,42 +73,37 @@ public function __construct(
     public function execute(int $stockId): array
     {
         try {
-            $sourceCodes = $this->getAssignedSourceCodes($stockId);
-
-            $searchCriteria = $this->searchCriteriaBuilder
-                ->addFilter(SourceInterface::SOURCE_CODE, $sourceCodes, 'in')
-                ->create();
-
-            $searchResult = $this->sourceRepository->getList($searchCriteria);
+            $stockSourceLinks = $this->getStockSourceLinks($stockId);
+            $sources = [];
+            foreach ($stockSourceLinks as $link) {
+                $sources[] = $this->sourceRepository->get($link->getSourceCode());
+            }
 
-            return $searchResult->getItems();
+            return $sources;
         } catch (\Exception $e) {
             $this->logger->error($e->getMessage());
             throw new LocalizedException(__('Could not load Sources for Stock'), $e);
         }
     }
 
     /**
-     * Get all linked SourceCodes by given stockId
+     * Get all stock-source links by given stockId.
      *
      * @param int $stockId
      * @return array
      */
-    private function getAssignedSourceCodes(int $stockId): array
+    private function getStockSourceLinks(int $stockId): array
     {
+        $sortOrder = $this->sortOrderBuilder
+            ->setField(StockSourceLinkInterface::PRIORITY)
+            ->setAscendingDirection()
+            ->create();
         $searchCriteria = $this->searchCriteriaBuilder
             ->addFilter(StockSourceLinkInterface::STOCK_ID, $stockId)
+            ->addSortOrder($sortOrder)
             ->create();
         $searchResult = $this->getStockSourceLinks->execute($searchCriteria);
 
-        if (0 === $searchResult->getTotalCount()) {
-            return [];
-        }
-
-        $sourceCodes = [];
-        foreach ($searchResult->getItems() as $link) {
-            $sourceCodes[] = $link->getSourceCode();
-        }
-        return $sourceCodes;
+        return $searchResult->getItems();
     }
 }

app/code/Magento/InventoryApi/Test/_files/stock_source_links.php

@@ -36,7 +36,7 @@
 $linksData = [
     10 => ['eu-1', 'eu-2', 'eu-3', 'eu-disabled'],
     20 => ['us-1'],
-    30 => ['eu-1', 'eu-2', 'eu-3', 'eu-disabled', 'us-1']
+    30 => ['us-1', 'eu-disabled', 'eu-3', 'eu-2', 'eu-1']
 ];
 
 

app/code/Magento/InventoryShipping/Block/Adminhtml/Order/View/Tab/SourceSelection.php

@@ -13,6 +13,7 @@
 use Magento\Framework\Registry;
 use Magento\InventoryApi\Api\SourceRepositoryInterface;
 use Magento\InventoryShipping\Model\ShippingAlgorithmProviderInterface;
+use Magento\InventoryShipping\Model\ShippingAlgorithmResult\ShippingAlgorithmResultInterface;
 use Magento\InventoryShipping\Model\ShippingAlgorithmResult\SourceSelectionInterface;
 
 /**
@@ -22,6 +23,11 @@
  */
 class SourceSelection extends Template implements TabInterface
 {
+    /**
+     * @var ShippingAlgorithmResultInterface
+     */
+    private $shippingAlgorithmResult;
+
     /**
      * @var Registry
      */
@@ -57,16 +63,24 @@ public function __construct(
         $this->sourceRepository = $sourceRepository;
     }
 
+    /**
+     * Check if order items can be shipped by the current shipping algorithm
+     *
+     * @return bool
+     */
+    public function isShippable()
+    {
+        return $this->getShippingAlgorithmResult()->isShippable();
+    }
+
     /**
      * Get source selections for order
      *
      * @return SourceSelectionInterface[]
      */
     public function getSourceSelections(): array
     {
-        $order = $this->registry->registry('current_order');
-        $shippingAlgorithm = $this->shippingAlgorithmProvider->execute();
-        return $shippingAlgorithm->execute($order)->getSourceSelections();
+        return $this->getShippingAlgorithmResult()->getSourceSelections();
     }
 
     /**
@@ -102,7 +116,7 @@ public function getTabTitle()
      */
     public function canShowTab()
     {
-        return true;
+        return $this->isShippable();
     }
 
     /**
@@ -112,4 +126,19 @@ public function isHidden()
     {
         return false;
     }
+
+    /**
+     * @return ShippingAlgorithmResultInterface
+     */
+    private function getShippingAlgorithmResult()
+    {
+        if (null === $this->shippingAlgorithmResult) {
+            $order = $this->registry->registry('current_order');
+            $shippingAlgorithm = $this->shippingAlgorithmProvider->execute();
+
+            $this->shippingAlgorithmResult = $shippingAlgorithm->execute($order);
+        }
+
+        return $this->shippingAlgorithmResult;
+    }
 }