Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move canSubtractQty move on website level #345

Closed
naydav opened this issue Dec 27, 2017 · 2 comments
Closed

Move canSubtractQty move on website level #345

naydav opened this issue Dec 27, 2017 · 2 comments
Assignees
@roma-glushko

Comments

@naydav
Copy link

naydav commented Dec 27, 2017

Now cataloginventory/options/can_subtract is related to store view level
Need to move this option to website level
@roma-glushko roma-glushko self-assigned this Dec 27, 2017
roma-glushko pushed a commit that referenced this issue Dec 27, 2017
#345 Refactored the Magento\CatalogInventory\Api\StockConfigurationIn…
980d56c 
…terface::canSubtractQty() to be used on the website scope
@roma-glushko
Copy link
Member

PR #357 has been created for this task. Thank you!

roma-glushko pushed a commit that referenced this issue Dec 28, 2017
#345 Configured the store configuration on the website level
40a83f2
roma-glushko pushed a commit that referenced this issue Jan 2, 2018
Revert "#345 Refactored the Magento\CatalogInventory\Api\StockConfigu…
1b53a69 
…rationInterface::canSubtractQty() to be used on the website scope"

This reverts commit 980d56c.
roma-glushko pushed a commit that referenced this issue Jan 2, 2018
Revert "#345 Configured the store configuration on the website level"
5baca32 
This reverts commit 40a83f2.
roma-glushko pushed a commit that referenced this issue Jan 2, 2018
#345 Overrode the scope of the store configuration
ce843b6
@roma-glushko
Copy link
Member

Hi @naydav The configuration scope was overridden from InventorySales module. Should we create any tests here? Thanks.

maghamed added a commit that referenced this issue Feb 1, 2018
@maghamed
#345 Configured the store configuration on the website level. Sequenc…
4f5b83c 
…es removed
maghamed added a commit that referenced this issue Feb 1, 2018
@maghamed
Merge pull request #357 from magento-engcom/345_assign_canSubtractQty…
75e5adf 
…_to_website_scope

#345 Refactored the StockConfigurationInterface::canSubtractQty() to be used on the website scope
@roma-glushko roma-glushko mentioned this issue Feb 1, 2018
Merged
@maghamed maghamed closed this as completed Feb 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@roma-glushko roma-glushko

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@naydav @maghamed @roma-glushko