#345 Refactored the StockConfigurationInterface::canSubtractQty() to be used on the website scope #357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…terface::canSubtractQty() to be used on the website scope
added 2 commits
December 28, 2017 15:27
…rationInterface::canSubtractQty() to be used on the website scope" This reverts commit 980d56c.
naydav
suggested changes
Jan 2, 2018
| @@ -13,7 +13,7 @@ | |||
| <resource>Magento_CatalogInventory::cataloginventory</resource> | |||
| <group id="options" translate="label" type="text" sortOrder="1" showInDefault="1" showInWebsite="1" showInStore="1"> | |||
| <label>Stock Options</label> | |||
| <field id="can_subtract" translate="label" type="select" sortOrder="2" showInDefault="1" showInWebsite="0" showInStore="0" canRestore="1"> | |||
| <field id="can_subtract" translate="label" type="select" sortOrder="2" showInDefault="1" showInWebsite="1" showInStore="0" canRestore="1"> | |||
There was a problem hiding this comment.
We can not change legacy(core) code
We need to override this option in new config in new InventorySales module
added 2 commits
January 2, 2018 22:40
maghamed
reviewed
Feb 1, 2018
| @@ -9,6 +9,7 @@ | |||
| <module name="Magento_InventorySales" setup_version="1.0.0"> | |||
| <sequence> | |||
| <module name="Magento_InventoryCatalog"/> | |||
| <module name="Magento_CatalogInventory"/> | |||
There was a problem hiding this comment.
this is wrong sequence, we no need to add CatalogInventory to any MSI module,
taking into account that MSI would be installed on top of Magento, CatalogInventory would be already installed.
magento-devops-reposync-svc
pushed a commit
that referenced
this pull request
Jun 13, 2023
Inventory fixes for Application server
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Moved the "Decrease Stock When Order is Placed" store configuration to the website scope.
Other modules will read this option on website scope as well.
Fixed Issues (if relevant)