Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MSI-1250: Prevent Disabling Default Source by Disabling 'Is Enabled' … #1391

Closed
wants to merge 2 commits into from

Conversation

larsroettig
Copy link
Member

Description

  • Add Plugin for disabling Is Enabled' Switcher
  • Refactore and Code Clean Up

Fixed Issues (if relevant)

#1250: Prevent Disabling Default Source by Disabling 'Is Enabled' Switcher
2. ...

Manual testing scenarios

  1. ...
  2. ...

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@larsroettig larsroettig requested a review from maghamed June 17, 2018 08:15
@larsroettig
Copy link
Member Author

@magento-engcom-team give me new test instance

@maghamed
Copy link
Contributor

pluginization of getMeta in the scope of which getData is called is wrong.
Because meta should not be coupled to data

@naydav
Copy link

naydav commented Jun 29, 2018

Closed due to #1410

@naydav naydav closed this Jun 29, 2018
@larsroettig larsroettig deleted the 1250-prevent-change-default-source branch November 4, 2018 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants